Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format streamgraph #843

Merged
merged 9 commits into from
Nov 29, 2018
Merged

Update format streamgraph #843

merged 9 commits into from
Nov 29, 2018

Conversation

youlot
Copy link
Collaborator

@youlot youlot commented Nov 27, 2018

No description provided.

@youlot youlot added the 👷‍♂️ Ready For Review PR en attente de relecture et de validation label Nov 27, 2018
@youlot youlot requested a review from touv November 27, 2018 18:37
Copy link
Contributor

@touv touv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failed, can you fix it ?

@youlot
Copy link
Collaborator Author

youlot commented Nov 28, 2018

I made some fixes for the tests but now they failed on the make install :

Pulling api (node:10)... 10: Pulling from library/node ERROR: no matching manifest for linux/amd64 in the manifest list entries make: *** [install-npm-dependencies] Error 1 The command "make install" failed and exited with 2 during .

I don't know what to do because those logs doesn't really help..

@touv
Copy link
Contributor

touv commented Nov 28, 2018

Maybe, we are in this case : docker-library/official-images#3835

@youlot
Copy link
Collaborator Author

youlot commented Nov 29, 2018

Yes, this is maybe the solution and it explains why the tests have passed now

@touv touv merged commit 6d2996b into master Nov 29, 2018
@touv touv deleted the update_format_streamgraph branch November 29, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👷‍♂️ Ready For Review PR en attente de relecture et de validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants