Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code style of source files #80

Merged
merged 8 commits into from
Apr 5, 2024
Merged

fix: code style of source files #80

merged 8 commits into from
Apr 5, 2024

Conversation

bednar
Copy link
Member

@bednar bednar commented Apr 2, 2024

Proposed Changes

This PR enable CI check for source file code style checking.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 2.11%. Comparing base (91e8b47) to head (f02e9ed).

Files Patch % Lines
influxdb_client_3/__init__.py 0.00% 12 Missing ⚠️
.../write_client/client/write/dataframe_serializer.py 0.00% 10 Missing ⚠️
influxdb_client_3/read_file.py 0.00% 3 Missing ⚠️
influxdb_client_3/write_client/client/_base.py 0.00% 3 Missing ⚠️
influxdb_client_3/write_client/client/write_api.py 0.00% 2 Missing ⚠️
influxdb_client_3/write_client/_sync/api_client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #80   +/-   ##
=====================================
  Coverage   2.11%   2.11%           
=====================================
  Files         34      34           
  Lines       2083    2080    -3     
=====================================
  Hits          44      44           
+ Misses      2039    2036    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review April 2, 2024 09:50
@bednar
Copy link
Member Author

bednar commented Apr 2, 2024

@karel-rehor, the Codecov report isn't applicable in this case due to the refactoring of the file styles.

@bednar bednar requested a review from karel-rehor April 2, 2024 09:52
Copy link
Contributor

@karel-rehor karel-rehor Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this example against an initial user account - it eventually resulted in the following error

The retriable error occurred during request. Reason: 'org fbb67cd4c8905be6 has exceeded limited_write plan limit'. Retry in 206s.

While a good example of batching, I'm not sure from perhaps a marketing perspective, if it is a good example for newer users.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue should be addressed by #82

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this example as well against a new user account. Apparently the "flight2" bucket needs to be created in another example.

Failed with error

pyarrow.lib.ArrowInvalid: Flight returned invalid argument error, with message: bucket "flight2" not found. gRPC client debug context: UNKNOWN:Error received from peer ipv4:34.196.233.7:443 {created_time:"2024-04-05T10:59:19.006603056+02:00", grpc_status:3, grpc_message:"bucket \"flight2\" not found"}. Client context: IOError: Server never sent a data message. Detail: Internal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue should be addressed by #82

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests pass. Could be more of them.
  • Linter (flake8) passes.
  • Tried running a few examples but they have issues.
    • Not self contained - some expect a prepared database state
    • One exceeded limits for introductory account
    • Some use outdated API, which has been refactored
    • Still with a few changes they can be executed
    • For these issues Enhancement Request examples: general review and restructuring of examples  #82 has been opened

Since this PR is basically about standardizing code style and removing detritus like unused import statements, it should not be necessary to address issues with examples here.

Good to go.

@bednar bednar merged commit 596f617 into main Apr 5, 2024
12 checks passed
@bednar bednar added this to the 0.4.0 milestone Apr 5, 2024
@bednar bednar deleted the code-style branch May 3, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants