feature: Using terraform together with infisical login. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
requested changes
Jul 2, 2024
| credentialsValue, err := GetValueInKeyring(userEmail) | ||
| if err != nil { | ||
| if err == keyring.ErrUnsupportedPlatform { | ||
| return UserCredentials{}, errors.New("your OS does not support keyring. Consider using a service token https://infisical.com/docs/documentation/platform/token") |
There was a problem hiding this comment.
Let's point users towards machine identities instead of service tokens
| @@ -140,7 +140,7 @@ func (d *SecretsDataSource) Read(ctx context.Context, req datasource.ReadRequest | |||
| for _, secret := range plainTextSecrets { | |||
| data.Secrets[secret.Key] = InfisicalSecretDetails{Value: types.StringValue(secret.Value), Comment: types.StringValue(secret.Comment), SecretType: types.StringValue(secret.Type)} | |||
| } | |||
| } else if d.client.Config.AuthStrategy == infisical.AuthStrategy.UNIVERSAL_MACHINE_IDENTITY { | |||
| } else if d.client.Config.AuthStrategy == infisical.AuthStrategy.UNIVERSAL_MACHINE_IDENTITY || d.client.Config.AuthStrategy == infisical.AuthStrategy.USER_PROFILE { | |||
| secrets, err := d.client.GetRawSecrets(data.FolderPath.ValueString(), data.EnvSlug.ValueString(), data.WorkspaceId.ValueString()) | |||
There was a problem hiding this comment.
GetRawSecrets() will fail here because inside the function we are doing a if machine identity client ID & client secret is empty, throw error
So currently this doesn't factor in the case where the user is using user-based auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enabled users to use terraform with Infisical CLI. It checks for machine identity, then service token and then finally checks for the keyring saved from infisical CLI.
User's must pass a profile argument or env
INFISICAL_USER_PROFILEto ensure the right one is picked from keyring. (In future when you have multiple profiles in via cli login).This improves ux as user's don't have to maintain the identity token for each project user and also good audit log.