Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add projects to Terraform Provider #34

Merged
merged 14 commits into from
Mar 27, 2024
Merged

Conversation

DanielHougaard
Copy link
Collaborator

@DanielHougaard DanielHougaard commented Feb 27, 2024

This PR introduces projects support for the Infisical Terraform Provider.

On the data source you can access environments by the environment slug like seen below.

You access environments like so, infisical_projects.test-project.environments["dev"]. The reason for making it accessible like an object rather than on an array-basis, is to improve the user experience when interacting with environments. This also conveniently fits our secrets implementation.

⚠️ Do not merge/release before the V2 project-slug based router (Infisical/infisical#1449) is released.

@DanielHougaard DanielHougaard added the enhancement New feature or request label Feb 27, 2024
@DanielHougaard DanielHougaard self-assigned this Feb 27, 2024
Copy link

gitguardian bot commented Feb 27, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9650964 Triggered Generic High Entropy Secret 11bde16 examples/resources/infisical_project/resource.tf View secret
9650964 Triggered Generic High Entropy Secret 5d3bed4 examples/resources/infisical_project/resource.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, really good work! Once we get the API PR merged, i'll try this out manually

client/api.go Show resolved Hide resolved
docs/resources/project.md Show resolved Hide resolved
@DanielHougaard DanielHougaard force-pushed the daniel/project-interactions branch from c1db22e to e2fa5d8 Compare March 22, 2024 17:46
Copy link
Contributor

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maidul98 maidul98 merged commit 38cfd8f into main Mar 27, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants