Merge pull request #56 from Infisical/daniel/fix-project-membership-d…

…rift

fix(project-user-resource): tf error if membership gets removed in infisical

internal/client/project_user.go

@@ -1,6 +1,9 @@
 package infisicalclient
 
-import "fmt"
+import (
+	"fmt"
+	"net/http"
+)
 
 func (client Client) InviteUsersToProject(request InviteUsersToProjectRequest) ([]ProjectMemberships, error) {
 	var inviteUsersToProjectResponse InviteUsersToProjectResponse
@@ -72,11 +75,16 @@ func (client Client) GetProjectUserByUsername(request GetProjectUserByUserNameRe
 		Post(fmt.Sprintf("api/v1/workspace/%s/memberships/details", request.ProjectID))
 
 	if err != nil {
-		return GetProjectUserByUserNameResponse{}, fmt.Errorf("CallCreateProject: Unable to complete api request [err=%s]", err)
+		return GetProjectUserByUserNameResponse{}, fmt.Errorf("CallGetProjectUserByUsername: Unable to complete api request [err=%s]", err)
 	}
 
 	if response.IsError() {
-		return GetProjectUserByUserNameResponse{}, fmt.Errorf("CallCreateProject: Unsuccessful response. [response=%s]", response)
+
+		if response.StatusCode() == http.StatusNotFound {
+			return GetProjectUserByUserNameResponse{}, ErrNotFound
+		}
+
+		return GetProjectUserByUserNameResponse{}, fmt.Errorf("CallGetProjectUserByUsername: Unsuccessful response. [response=%s]", response)
 	}
 
 	return projectUserResponse, nil

internal/provider/resource/project_user_resource.go

@@ -345,11 +345,18 @@ func (r *ProjectUserResource) Read(ctx context.Context, req resource.ReadRequest
 		ProjectID: state.ProjectID.ValueString(),
 		Username:  state.Username.ValueString(),
 	})
+
 	if err != nil {
+		if err == infisical.ErrNotFound {
+			resp.State.RemoveResource(ctx)
+			return
+		}
+
 		resp.Diagnostics.AddError(
 			"Error fetching user",
 			"Couldn't find user in project, unexpected error: "+err.Error(),
 		)
+
 		return
 	}