feat: resolved linting issue

Infisical · Nov 20, 2024 · 46aa5bf · 46aa5bf
1 parent 2e1506a
commit 46aa5bf
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 8 deletions.
diff --git a/...testacc/project_resource_resource_test.go → internal/testacc/project_resource_test.go b/...testacc/project_resource_resource_test.go → internal/testacc/project_resource_test.go
@@ -57,6 +57,9 @@ func TestAccProject(t *testing.T) {
 							projectDetail, err := infisicalApiClient.GetProjectById(infisicalclient.GetProjectByIdRequest{
 								ID: id.(string),
 							})
+							if err != nil {
+								return err
+							}
 
 							slug, err := tfjsonpath.Traverse(resource.AttributeValues, tfjsonpath.New("slug"))
 							if err != nil {
@@ -119,6 +122,10 @@ func TestAccProject(t *testing.T) {
 							projectDetail, err := infisicalApiClient.GetProjectById(infisicalclient.GetProjectByIdRequest{
 								ID: id.(string),
 							})
+							if err != nil {
+								return err
+							}
+
 							slug, err := tfjsonpath.Traverse(resource.AttributeValues, tfjsonpath.New("slug"))
 							if err != nil {
 								return err

diff --git a/internal/testacc/project_role_resource_test.go b/internal/testacc/project_role_resource_test.go
@@ -51,6 +51,9 @@ func TestAccProjectRole(t *testing.T) {
 								ProjectSlug: projectSlug.(string),
 								RoleSlug:    roleName,
 							})
+							if err != nil {
+								return err
+							}
 
 							slug, err := tfjsonpath.Traverse(resource.AttributeValues, tfjsonpath.New("slug"))
 							if err != nil {
@@ -109,6 +112,9 @@ func TestAccProjectRole(t *testing.T) {
 								ProjectSlug: projectSlug.(string),
 								RoleSlug:    roleName,
 							})
+							if err != nil {
+								return err
+							}
 
 							slug, err := tfjsonpath.Traverse(resource.AttributeValues, tfjsonpath.New("slug"))
 							if err != nil {

diff --git a/internal/testacc/project_user_resource_test.go b/internal/testacc/project_user_resource_test.go
@@ -56,6 +56,9 @@ func TestAccProjectUser(t *testing.T) {
 								ProjectID: projectId.(string),
 								Username:  email,
 							})
+							if err != nil {
+								return err
+							}
 
 							membershipId, err := tfjsonpath.Traverse(resource.AttributeValues, tfjsonpath.New("membership_id"))
 							if err != nil {

diff --git a/internal/testacc/testing.go b/internal/testacc/testing.go
@@ -42,7 +42,7 @@ func init() {
 		if v := os.Getenv(env); v != "" {
 			env_values = append(env_values, v)
 		} else {
-			fmt.Errorf("%s must be set for acceptance tests", err)
+			log.Fatalf("%v must be set for acceptance tests", err)
 		}
 	}
 
@@ -91,7 +91,7 @@ func protoV6ProviderFactories() map[string]func() (tfprotov6.ProviderServer, err
 	}
 }
 
-// preCheck checks if all conditions for an acceptance test are
+// preCheck checks if all conditions for an acceptance test are.
 func preCheck(t *testing.T) func() {
 	return func() {
 		rootDir, err := findProjectRoot()
@@ -167,12 +167,12 @@ func loadEnvFile(filename string) error {
 	return godotenv.Load(filename)
 }
 
-func getEnv(key, fallback string) string {
-	if value, ok := os.LookupEnv(key); ok {
-		return value
-	}
-	return fallback
-}
+// func getEnv(key, fallback string) string {
+// 	if value, ok := os.LookupEnv(key); ok {
+// 		return value
+// 	}
+// 	return fallback
+// }
 
 func getIdentityOrgId() string {
 	if v := os.Getenv(IDENTITY_TEST_ORG_ID_ENV); v != "" {