Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21.4 ASPaper (EXPERIMENTAL) #148

Draft
wants to merge 270 commits into
base: develop
Choose a base branch
from
Draft

1.21.4 ASPaper (EXPERIMENTAL) #148

wants to merge 270 commits into from

Conversation

ComputerNerd100
Copy link
Member

Updates ASPaper to 1.21.4 (pre hard-fork, latest paper commit)

Experimental as:

  • Untested (builds and server starts, nothing else checked yet)
  • Paper 1.21.4 builds are still experimental

IS_Bot and others added 30 commits August 17, 2024 00:30
…02b0fc6a24

Migrate ArmorStand meta to using entity tag (#11107)
…87951d277d

Add Configuration for vertical Despawn Ranges (#11279)
…5c0bf72b39

Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11284)

Updated Upstream (Bukkit/CraftBukkit/Spigot)

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
4068c6aa PR-1053: Change docs for max power in FireworkMeta
6b3c241b SPIGOT-7783, SPIGOT-7784, PR-1051: Add Trial Vault & Spawner event API
5fe300ec PR-1052: Fix broken links and minor improvement for checkstyle.xml

CraftBukkit Changes:
7548afcf2 SPIGOT-7872: Fix crash with event-modified teleports
93480d5d6 SPIGOT-7868, PR-1463: Fix default and max power in FireworkMeta
5060d1a84 SPIGOT-7783, SPIGOT-7784, PR-1460: Add Trial Vault & Spawner event API
11dfcae71 PR-1462: Fix broken links and minor improvement for checkstyle.xml

Spigot Changes:
ca581228 Rebuild patches
…e59fdeace9

Update item data sanitization (#11227)
…a48f5ec346

Add even more Enchantment API (#11115)
…c5fa8e5b65

Fix Selector Arguments not working with permission (#11286)
…e61e19d719

Fix CraftBukkit drag system (#10703)
…02e22fddf3

Allow getting/setting the sign's editor uuid (#10637)

* Allow getting/setting the sign's editor uuid

* rebased

---------

Co-authored-by: Jake Potrebic <[email protected]>
…f4275c85ce

Fix entity limit patch deleting unnecessary entities

We need to continue the save loop, not break from it
when a limit is reached.
…3c3f96f6e8

Use player file, not directory, when checking for offline player data

When trying to fall back to offline player data in onlide mode,
we need to use the player file. This fixes a mistake during
update where 'file' was used, but the new code uses 'file1'
for the player file.
…66ffdfc281

[ci skip] Clean up book limits patch (#11297)
…eb42d7f0df

Add getWorld method that uses adventure Key (#11199)
…6bb3049275

Allow server administrators to disable book size checks (#10457)
…3a454545ab

[ci skip] Fix JavaDocs for HeightMap#MOTION_BLOCKING_NO_LEAVES (#11291)
…3a454545ab

[ci skip] Fix JavaDocs for HeightMap#MOTION_BLOCKING_NO_LEAVES (#11291)

Automatically updated to Paper commit: ba1b0162faaa7bf78d33162f6976586bb3049275
Allow server administrators to disable book size checks (#10457)

Automatically updated to Paper commit: dae906ba452e4a17779aa6438ccd6deb42d7f0df
Add getWorld method that uses adventure Key (#11199)

Automatically updated to Paper commit: 8fd3a67138b5d7a3a21e059eb3c3b766ffdfc281
[ci skip] Clean up book limits patch (#11297)

Automatically updated to Paper commit: be1078f5f2e28c1a1de99e9c96e4003c3f96f6e8
Use player file, not directory, when checking for offline player data

When trying to fall back to offline player data in onlide mode,
we need to use the player file. This fixes a mistake during
update where 'file' was used, but the new code uses 'file1'
for the player file.

Automatically updated to Paper commit: b4bc512cac4d75f9e366479c5d8fdcf4275c85ce
Fix entity limit patch deleting unnecessary entities

We need to continue the save loop, not break from it
when a limit is reached.

Automatically updated to Paper commit: 64c9ee6584ce15e5b486bdc7183fe902e22fddf3
Allow getting/setting the sign's editor uuid (#10637)

* Allow getting/setting the sign's editor uuid

* rebased

---------

Co-authored-by: Jake Potrebic <[email protected]>

Automatically updated to Paper commit: 44017487a81534067fd17e2d5e8669e61e19d719
Fix CraftBukkit drag system (#10703)

Automatically updated to Paper commit: 8c3018a4b177aa0f7658d510bf7d19c5fa8e5b65
Fix Selector Arguments not working with permission (#11286)

Automatically updated to Paper commit: 57dd822393df78a4cb47f7a2c2d037dc2a77d5bd
Leashable API (#10961)

Automatically updated to Paper commit: 2e82fd2d2c1881665e27654977390fa48f5ec346
Add even more Enchantment API (#11115)

Automatically updated to Paper commit: 66a97cc929740475bc8dd192382c4ae59fdeace9
Update item data sanitization (#11227)

Automatically updated to Paper commit: 0e7361704a16c8386d829c26603f3e5c0bf72b39
Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11284)

Updated Upstream (Bukkit/CraftBukkit/Spigot)

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
4068c6aa PR-1053: Change docs for max power in FireworkMeta
6b3c241b SPIGOT-7783, SPIGOT-7784, PR-1051: Add Trial Vault & Spawner event API
5fe300ec PR-1052: Fix broken links and minor improvement for checkstyle.xml

CraftBukkit Changes:
7548afcf2 SPIGOT-7872: Fix crash with event-modified teleports
93480d5d6 SPIGOT-7868, PR-1463: Fix default and max power in FireworkMeta
5060d1a84 SPIGOT-7783, SPIGOT-7784, PR-1460: Add Trial Vault & Spawner event API
11dfcae71 PR-1462: Fix broken links and minor improvement for checkstyle.xml

Spigot Changes:
ca581228 Rebuild patches

Automatically updated to Paper commit: 75655ec1d34f344c7b0ba9f31f2ada87951d277d
Add Configuration for vertical Despawn Ranges (#11279)

Automatically updated to Paper commit: 52ae4ad4666b34d637f2de573ed03c02b0fc6a24
Migrate ArmorStand meta to using entity tag (#11107)

Automatically updated to Paper commit: d5ffc573dc17092ea2cfdd4ce14dac3e70b932f5
Implement more methods for horse inventories (#11147)

Automatically updated to Paper commit: 4829fbf6bd51e2dc86e2f190971c081aac76a201
Handle custom registry elements properly (#11230)

* Handle custom registry elements properly

* update error message

Datapack made painting variant support is added in PaperMC/Paper#11244

* change msg for art conversion

---------

Co-authored-by: Jake Potrebic <[email protected]>

Automatically updated to Paper commit: 78216fef26e454c78dff5e495f6ebe673be56900
Re-implement portalCreateRadius world config (#11267)

Automatically updated to Paper commit: e619744fbdc4963eed0b04c1e44bd1089ce50285
Allow skipping of world symlink validation (#11250)

Automatically updated to Paper commit: 534ab86010330ce3afa732910227585d0dc02d1e
[ci-skip] Revert "Add Configuration for vertical Despawn Ranges (#10440)" (#11278)

This reverts commit 1b8ab116edd5da15791de96aa462db90756848dc.

Automatically updated to Paper commit: 1b8ab116edd5da15791de96aa462db90756848dc
Add Configuration for vertical Despawn Ranges (#10440)

Automatically updated to Paper commit: ec55c11fc074929e4aa1a1ecdaef51da69dbf0be
Fix indestructable light blocks (#11275)

Co-authored-by: Bjarne Koll <[email protected]>

Automatically updated to Paper commit: 95719832bf57ae523982d681cd219e8387c39955
Fix scanForLegacyEnderDragon world config (#11262)

Automatically updated to Paper commit: 81bfda87103e1a47ea184c5da119e79218a8dc1e
[ci skip] Specify rebase location in CONTRIBUTING (#11255)

* [ci skip] Specify rebase location in CONTRIBUTING

* Improve

* remove Paper-MojangAPI mention

---------

Co-authored-by: Bjarne Koll <[email protected]>
Co-authored-by: Lulu13022002 <[email protected]>

Automatically updated to Paper commit: fb530743e5c71cb4faba06339bdeb14a33e06a6a
Apply optimise collision checking in move packet handling patch

Automatically updated to Paper commit: bf5852a6151aa643b87bd0e0f9e3940f867064a3
Fix NPE for PlayerPostRespawnEvent#getRespawnedLocation (#11268)

Automatically updated to Paper commit: 11b4ac7c659ffb7e4790b0856b14117b6d532200
Fix disableEndCredits world config (#11261)

Automatically updated to Paper commit: 9ab644ed290542a9e537d8f529bc6898a3da2e7d
Fix `TooltipContext.create` being wrong(#11254)

Co-authored-by: Jake Potrebic <[email protected]>

Automatically updated to Paper commit: 7c9240f4a63b13be1fdcedbfb0270f9b49b75518
Improve standard messenger logging

Automatically updated to Paper commit: 1798e949e5727f376ccaee51873f21dcdedc9a5f
Fix BasicCommand suggestion arg count (#11241)

Automatically updated to Paper commit: 4a97ba3ea8cb449fe76ed1aef0b572e7cc01d542
Fix `setSendViewDistance`'s return (#11247)

Automatically updated to Paper commit: f97aff74b6f7fd4940c0c0b6cca3f8ac6e1afdef
[ci skip] Fix Effect javadocs (#11182)

Automatically updated to Paper commit: 098bd39092f50cb97a604c2f228f2af29666ca41
Remove arbitrary book page limit (#11228)

Automatically updated to Paper commit: ab0d24aa6f22308352eb363b09c992fc70de4143
Configuration for horizontal-only item merging (#11219)
Migrate back to the gradleup shadow plugin and upgrade version to 8.3.0
…9433800bf2

Fix SculkBloomEvent firing for block entity loading (#11306)
…cc2a6954d2

Fix structure check API (#11307)

* Fix structure check API

* Use CraftStructure#bukkitToMinecraft

* Fixed spelling mistake on CraftStructure class name
# Conflicts:
#	gradle.properties
Fix typo: worldData.name() was added twice to WorldsInUse instead of being removed.
…c1813da41d

Ensure MaterialChoice materials are items (#11325)
…f030eca34d

Prevent duplicate pickup event for piglins (#11322)
IS_Bot and others added 16 commits December 5, 2024 23:11
…9f1292cbcf

Fix broken joml metadata resulting in kotlin being included on compile/runtime classpath (#11712)
…71e0980a29

Add ItemMeta customName methods (#11685)
…6438707158

Update getKey impls for inlineable types
…4289632016

Switch Impl types to Holderable (#11662)

* Switch Impl types to Holderable

* Fix compile issues

* more improvements

* compile fixes

* remove unneeded unwrapAndConvertHolder call

---------

Co-authored-by: Bjarne Koll <[email protected]>
…7d1e3eac56

Brigadier: fix simpleUnwrap not keeping redirect modifier and forks properties from original node (#11654)
…105dafc4ea

Add command block material tags (#11720)
…ff65dfcc81

Fix incorrect command serialization by creating new Command (#11671)

Fixes #11649 - As noted in the issue, when CommandNodes are serialized
they are used as the key in a Map. Their equals()/hashcode() should only    match if they are equal nodes (name & command), but due to the erasure of the command field pre-serialization, nodes with different commands can be mapped onto the same value. This causes the client to interpret both nodes as the same, causing suggestions where they should not.

This is fixed by creating a different no-op command for the
erasure, instead of them holding the same lambda.
…fdce1f3b03

Readd shear methods from bukkit Shearable (#11715)

* Re-add shear methods from bukkit Shearable

* Add back
…6de45f7444

Fix/scoreboard delegate (#11453)
Update to the newest paper build and resolve chunk issues
@kyngs
Copy link
Member

kyngs commented Dec 15, 2024

lgtm (so far)

@CommandDan
Copy link

I assume lgtm means "Let's go test/testing mate"

lol I have no clue what it means

@davidmayr
Copy link

davidmayr commented Dec 15, 2024

I assume lgtm means "Let's go test/testing mate"

lol I have no clue what it means

LGTM means legitimate looks good to me
Basically, kyngs said that it looks good so far.

And sure, you can test this build. But keep in mind it's based on an experimental paper build and ASP does not account for any data loss or corrupted worlds

@CommandDan
Copy link

Yea I know about the testing. It was a joke.

It should honestly be lgtmt so that each syllable has a letter. The mate was in there xD

My comment was meant to get to know what lgtm means and now I do.

@davidmayr
Copy link

Yea I know about the testing. It was a joke.

It should honestly be lgtmt so that each syllable has a letter. The mate was in there xD

My comment was meant to get to know what lgtm means and now I do.

Well, you basically cant expect people to think about if a software is stable nowadays, so it has to be said. But thinking about your comment it made me google it why there is no "t" at the end and I found that I'm in a minority with calling it "legitimate" and people usually mean "looks good to me" (which basically means the same in this context) but this way it makes more sense

But enough of this now, since it's unrelated to the PR

(TIL - don't accidentally press H while having a patch open...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants