Update code for compatibility with PHP8 #119
Draft
+333
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secure_msg and the user_helper may be removed soon as it is likely they are unused.
|
@JimBacon presumably this can be closed now? |
|
I'd be inclined to close this without merging and re-open #118. We have not addressed the broken, and redundant code that is in secure_msg.php and the site_user/authenticate_user service. I think we can be confident now that it is unused since it is broken. The mcrypt library is no longer packaged with PHP. It could be obtained from PECL, if we wanted it, but the functions are all deprecated so it would still throw errors. The solution now seems to be to strip out that code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118