New Fuselage Model plus Minor Improvements #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test case for new feature which allows SHARPy to consider fuselage effects - includes input parameters and function to generate structural and aerodynamic input files - solver setup is still missing
- stores input parameter for later grid generation in h5 file - input radius for each specific beam node is generated automatically
- aerodynamic boundary conditions for fuselage wing junctions are stored in h5 aero file for later use in SHARPy
- settings are copied and pasted from simple HALE case for the beginning
- remove library as it is unused and might cause problems with Travis
- nonlifting_body_grid contains similiar to Aerogrid all information of the grid of panels but for nonlifting bodies/surfaces instead of lifting surfaces - grid class serves as a parent class from which nonlifting_body_grid is inheritated from, and later also Aerogrid
- NonliftingBodyTimeStepInfo is similar to AeroTimestepInfo but contains the relevant aerodynamic attributes for a single time step for nonlifting bodies instead of nonlifting surfaces - Its parent class TimeStepInfo will later also be used as a parent class for AeroTimeStepInfo
- functionality of class remains unchanged
- functionality of Aerogrid class remains unchanged - rename attributes for proper inheritance
- Nodes position are first calculate in B frame and are then converted to the A frame - add necessary and delete unnecessary imported packages
- Gridloader acts as a parent class for nonliftingbodygridloader class - Nonliftingbodygridloader generates aerodynamic grid for nonlifitng bodies similiar to aerogrid
- allows to simplify AerogridTimeStepInfo as a side effect since the array dimensions align with NonliftingBodyTimeStepInfo now
- Delete functions that are no longer needed since zeta contains only grid nodes instead of collocation points
- new function starts different UVLM function to calculate nonlifting bodies
- does not save the timestep infos - also removed unused attribute ts_max
- fetch error in git pull request build test - I am trying to update it top the latest version in the next commit, but for now I need to revert to an older one!
- back to the latest version, I hope it works.
- inputs needed to be added in the listed solvers to avoid bugs during unittesting - these inputs have been adjusted to the other solvers
- adjusted to equations in a document
- must have been removed during a merge process as it is included in the current SHARPy version
- also includes adjustments made in uvlmlib after renaming some interface functions
- improve flight condition definitions - remove unncessary comments
- copy and paste went horribly wrong before - unittests are running for these cases again
- achieved by coarser discretisation, lower fsi tolerances and steps
only_lifting instead of lifting_only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear team,
As promised, this is the big pull request mainly including methods to model nonlifting bodies such as fuselages with SHARPy.
Nonlifting Body Model Capabilities
The main changes are in the UVLM:
In SHARPy directly, the following c
Unittest
Unittest is successfully running and the following tests have been added to check the new capabilities:
Further all dynamic unittests have been speed up for quicker checks using coarser discretisation, and smaller fsi tolerances and substeps.
Documentation
Besides the usual documentation of code, the SHARPy docs and Readme have been updated. For the UVLM, a code documentation has been started that covers 80 % of the code for now.
Additional Notes
This branch has been successfully used to create plots for one of my journal papers as documented in this repository of mine https://github.com/sduess/Enhanced_UVLM_nonlinear_aeroelastic.