Follow PEP8 standard on library imports. import has higher `precede…
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
Oct 29, 2024
Comment on lines
288
to
+291
| from dataclasses import dataclass | ||
| import numpy as np | ||
| from scipy.stats import norm | ||
| from typing import Callable, Tuple | ||
| import numpy as np |
There was a problem hiding this comment.
Actually, this should be slightly different. import x ... comes before from x import ... but also, in-built packages should be imported in a block before external ones and the blocks should be separated by a newline.
from dataclasses import dataclass
from typing import Callable, Tuple
import numpy as np
from scipy.stats import norm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the pedantic and the ones who follow PEP8.
I modified the top-level import statements for the section containing the Python code.