Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ie support #156

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add ie support #156

merged 1 commit into from
Nov 1, 2024

Conversation

igoroctaviano
Copy link
Collaborator

Update Babel configuration for IE 11 compatibility

-Request: Target IE 11 #35

Description

Updates the Babel configuration to align with other dcmjs-org libraries by providing an IE 11 compatible build out of the box. This change will make the package easier to use as a dependency since consumers targeting IE 11 won't need to transpile this dependency on every build.

Changes

  • Removed node: 'current' target as it's not necessary (Jest tests work fine without it)
  • Removed redundant @babel/plugin-proposal-object-rest-spread plugin since it's included in @babel/preset-env by default
  • Simplified configuration to target IE 11 browsers, matching the approach used in other dcmjs-org repositories

Notes

  • This configuration ensures compatibility with IE 11 while maintaining support for all modern browsers
  • The simplified configuration follows the pattern established in other dcmjs-org libraries (e.g., dcmjs)
  • No functional changes to the codebase, only build configuration updates

Related

Follows the pattern from: https://github.com/dcmjs-org/dcmjs/blob/master/.babelrc

@igoroctaviano igoroctaviano merged commit 1dc53db into master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants