Skip to content

Commit

Permalink
Return void according to the function signatures
Browse files Browse the repository at this point in the history
  • Loading branch information
Mikhail Galanin authored and Danack committed Jun 25, 2024
1 parent 6ba5d0e commit bb38671
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 18 deletions.
21 changes: 4 additions & 17 deletions imagick_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -8308,7 +8308,7 @@ PHP_METHOD(Imagick, cropThumbnailImage)
}
/* }}} */

/* {{{ proto bool Imagick::resetIterator();
/* {{{ proto void Imagick::resetIterator();
Resets the iterator. Use it in conjunction with Imagick::nextImage() to iterate over all the images in a wand container.
*/
PHP_METHOD(Imagick, resetIterator)
Expand All @@ -8322,11 +8322,10 @@ PHP_METHOD(Imagick, resetIterator)

/* No magick is going to happen */
if (intern->magick_wand == NULL) {
RETURN_FALSE;
return;
}
intern->next_out_of_bound = 0;
MagickResetIterator(intern->magick_wand);
RETURN_TRUE;
}
/* }}} */

Expand Down Expand Up @@ -13198,7 +13197,7 @@ PHP_METHOD(Imagick, filter)
#endif //#if MagickLibVersion < 0x700
#endif // #ifdef IMAGICK_WITH_KERNEL

/* {{{ proto int Imagick::setAntiAlias(bool antialias)
/* {{{ proto void Imagick::setAntiAlias(bool antialias)
Set whether antialiasing should be used for operations. On by default.
*/
PHP_METHOD(Imagick, setAntialias)
Expand All @@ -13219,8 +13218,6 @@ PHP_METHOD(Imagick, setAntialias)
php_imagick_convert_imagick_exception(intern->magick_wand, "Unable to setAntiAlias" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */

Expand Down Expand Up @@ -13301,8 +13298,6 @@ PHP_METHOD(Imagick, optimizeImageTransparency)
php_imagick_convert_imagick_exception(intern->magick_wand, "Optimize image transparency failed" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif
Expand Down Expand Up @@ -13332,8 +13327,6 @@ PHP_METHOD(Imagick, autoGammaImage)
php_imagick_convert_imagick_exception(intern->magick_wand, "autoGammaImage" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif //#if MagickLibVersion >= 0x660
Expand Down Expand Up @@ -13362,8 +13355,6 @@ PHP_METHOD(Imagick, autoOrient)
php_imagick_convert_imagick_exception(intern->magick_wand, "Unable autoOrient image" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif // #if MagickLibVersion >= 0x692
Expand Down Expand Up @@ -13406,7 +13397,7 @@ PHP_METHOD(Imagick, compositeImageGravity)
#endif

#if MagickLibVersion >= 0x693
/* {{{ proto bool Imagick::localContrastImage(float radius, float strength)
/* {{{ proto void Imagick::localContrastImage(float radius, float strength)
Attempts to increase the appearance of large-scale light-dark transitions.
Local contrast enhancement works similarly to sharpening with an unsharp mask,
however the mask is instead created using an image with a greater blur distance.
Expand All @@ -13433,8 +13424,6 @@ PHP_METHOD(Imagick, localContrastImage)
php_imagick_convert_imagick_exception(intern->magick_wand, "Failed to localContrastImage" TSRMLS_CC);
return;
}

RETURN_TRUE;
}
/* }}} */
#endif // #if MagickLibVersion >= 0x693
Expand Down Expand Up @@ -13535,8 +13524,6 @@ PHP_METHOD(Imagick, setImageMask)
// You want ei->severity. ei->error_number
// the Go Imagick library does something like:
//return &MagickWandException{ExceptionType(C.int(et)), C.GoString(csdescription)}

RETURN_TRUE;
}
/* }}} */
#endif // IM_HAVE_IMAGICK_GETSETIMAGEMASK
Expand Down
1 change: 0 additions & 1 deletion imagickpixeliterator_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ PHP_METHOD(ImagickPixelIterator, resetIterator)
#if MagickLibVersion <= 0x628
internpix->iterator_position = 0;
#endif
RETURN_TRUE;
}
/* }}} */

Expand Down

0 comments on commit bb38671

Please sign in to comment.