Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of arbitraries #207

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jprudent
Copy link
Contributor

@jprudent jprudent commented Jan 15, 2024

Hello @Iltotore
This is a tiny PR that improves the generators.

All generators are guaranteed to generate values with a 100% success
rate. The testGen function checks that. In case of exhausted case, an
exception is thrown.

Some generators had to be written specifically for that purpose.

Most of string generators reuse the collection generators.

Thanks for your project.

@jprudent jprudent force-pushed the fix_scalacheck_assertions branch from e522ba0 to 6e59cae Compare January 15, 2024 08:56
@jprudent jprudent changed the title 🐛 Exhausted test case is thrown 🐛 Throw exhausted test cases Jan 15, 2024
@jprudent jprudent force-pushed the fix_scalacheck_assertions branch from 0e1b368 to f354af3 Compare January 31, 2024 20:45
All generators are guaranteed to generate values with a 100% success
rate. The testGen function checks that. In case of exhausted case, an
exception is thrown.

Some generators had to be written specifically for that purpose.

Most of string generators reuse the collection generators.
@jprudent jprudent force-pushed the fix_scalacheck_assertions branch from f354af3 to e75a77f Compare January 31, 2024 20:48
@jprudent jprudent changed the title 🐛 Throw exhausted test cases Improve performance of arbitraries Jan 31, 2024
@jprudent jprudent marked this pull request as ready for review January 31, 2024 20:51
Copy link
Owner

@Iltotore Iltotore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @jprudent is the PR ready?

@jprudent
Copy link
Contributor Author

jprudent commented Feb 5, 2024

cool, ready on my side, thanks !

@Iltotore Iltotore merged commit 8eca597 into Iltotore:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants