Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Pisces recognize the base quality score from PacBio HiFi reads? #57

Open
turningA opened this issue Dec 8, 2020 · 2 comments
Open

Comments

@turningA
Copy link

turningA commented Dec 8, 2020

I do notice that in your source code you have the following setup:
private const int MaxBaseQuality = 93;

It looks like it will tolerate the base quality until 93.

But I want to confirm with you: whether Pisces is able to recognize the base quality if it is higher than 41?

@turningA
Copy link
Author

turningA commented Dec 8, 2020

I capped the base quality to 41 and get the same variant calls.

@tamsen
Copy link
Contributor

tamsen commented Dec 17, 2020

Hi,

Thanks for using Pisces!

By default, Pisces accepts all bases over Q20, with equal weight. (We tried other methods and saw no improvement to accuracy, it just slowed things down. The knobs for monkeying with that model are still exposed if anyone wants to try anything different). Generally speaking, the only time the differences in high-scoring base call Q scores make a difference to variant calls is when the stitcher or Gemini is trying to make a decision on how to stitch reads who have different mismatches or cigar string differences in the overlap region, in which case the higher scores take precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants