Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error when Python is not installed #553

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

knyazer
Copy link

@knyazer knyazer commented Dec 22, 2024

Description

I'm using a dev-container setup with distrobox, with everything besides the OS shared between the container and the host system. Python is not installed on the host system, but it is installed in the container. All vars are shared between the system and the container, so the host thinks that it is in the python environment, while the environment is not installed.

This fix shows nothing if there is no python available.

Motivation and Context

Shows error if VIRTUAL_ENV is well-defined, but python is not there.

Closes #

Screenshots (if appropriate)

How Has This Been Tested

Just checked on my machine; the change is trivial, so I don't think it needs heavy testing..

  • I have tested using Linux.
  • I have tested using MacOS.

Checklist

  • I am ready to update the wiki accordingly. (not relevant)
  • I have updated the tests accordingly.

@knyazer knyazer requested a review from IlanCosman as a code owner December 22, 2024 18:32
@knyazer
Copy link
Author

knyazer commented Dec 22, 2024

Oh, yikes, I just copied the code instead of formatting it well... will finish it in a few hours :)

@knyazer knyazer marked this pull request as draft December 22, 2024 18:34
@knyazer knyazer marked this pull request as ready for review December 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant