Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zig item #452

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Add Zig item #452

merged 2 commits into from
Oct 7, 2023

Conversation

TheFunctionalGuy
Copy link
Contributor

Description

This PR adds support for a Zig prompt item.

Note: I was unsure whether I needed to update the tide_pwd_markers variable.

How Has This Been Tested

I have added a test case that contains 3 test cases:

  1. Being in a directory without a build.zig file should result in no item
  2. Being in a directory with a build.zig and zig version 0.11.0 should result in a prompt like: ZIG_LOGO 0.11.0
  3. Being in a directory with a build.zig and zig version 0.12.0-dev.789+e6590fea1 should result in a prompt like: ZIG_LOGO 0.12.0-dev so you know that your current version is a dev build
  • I have tested using Linux.
  • I have tested using MacOS. (I have no access to a Mac so I cannot test this)

Checklist

  • I am ready to update the wiki accordingly.
  • I have updated the tests accordingly.

Copy link
Owner

@IlanCosman IlanCosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fantastic PR. You nailed pretty much everything, down to the minute details!

@IlanCosman IlanCosman merged commit 7f9d24d into IlanCosman:main Oct 7, 2023
5 checks passed
@TheFunctionalGuy
Copy link
Contributor Author

Thank you. Am I allowed to update the Wiki? Because it says: not yet updated for v6.

@IlanCosman
Copy link
Owner

Yes, please do! Much appreciated :)

@TheFunctionalGuy
Copy link
Contributor Author

Done. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants