Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the Learn & Discover page #215

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

aperezdc
Copy link
Member

@aperezdc aperezdc commented Feb 28, 2024

  • Rewrite the leading text.
  • Organize link columns into describing WPE and its role as embedded browser, and the other for developer resources.
  • Moved links from subheadings into body text, to avoid confusion as it was not completely clear the subheadings were links.
  • Use more Markdown where possible, less HTML, for ease of editing.
  • Added dashed line below link columns, and slightly increse font size in the columns to visually separate them better and convey structure.
  • Made all the subheadings the same size, which as a side effect needed changing the identifier for the WPE showcase table.

Related issue: #184

Thanks to @csaavedra for the help with this 🤗


Site preview: https://igalia.github.io/wpewebkit.org/aperezdc/learn-discover-rework/

@aperezdc aperezdc added the enhancement New feature or request label Feb 28, 2024
@aperezdc aperezdc self-assigned this Feb 28, 2024
@aperezdc aperezdc requested a review from bkardell as a code owner February 28, 2024 15:35
- Rewrite the leading text.
- Organize link columns into describing WPE and its role as embedded
  browser, and the other for developer resources.
- Moved links from subheadings into body text, to avoid confusion as it
  was not completely clear the subheadings were links.
- Use more Markdown where possible, less HTML, for ease of editing.
- Added dashed line below link columns, and slightly increse font size
  in the columns to visually separate them better and convey structure.
- Made all the subheadings the same size, which as a side effect needed
  changing the identifier for the WPE showcase table.

Related issue: #184
@aperezdc aperezdc force-pushed the aperezdc/learn-discover-rework branch 2 times, most recently from 7d414ad to 037fffb Compare February 28, 2024 15:45
@aperezdc
Copy link
Member Author

Sharing a screenshot, as the PR preview is not working:

Screenshot 2024-02-28 at 17-46-35 Learn & Discover

Copy link
Member

@meyerweb meyerweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bkardell
Copy link
Member

bkardell commented Mar 6, 2024

lgtm - wth with preview again :(

Copy link
Member

@bkardell bkardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkardell bkardell merged commit 59d8c19 into master Mar 6, 2024
2 checks passed
@bkardell bkardell deleted the aperezdc/learn-discover-rework branch March 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants