Clean / Update pr.yml #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems that this is currently building a > 2gb artifact as it just keeps growing - I'd like to let it clean so we can verify if this is the whole issue, we can go back to true after. We'd need to rerun any existing prs
meyerweb
approved these changes
Jan 26, 2024
aperezdc
reviewed
Jan 28, 2024
| @@ -32,7 +32,7 @@ jobs: | |||
| with: | |||
| github_token: ${{ secrets.GITHUB_TOKEN }} | |||
| publish_dir: ./_site | |||
| keep_files: true | |||
| keep_files: false | |||
There was a problem hiding this comment.
This will make only the latest generated preview visible, which is not ideal.
bkardell
added a commit
that referenced
this pull request
Jan 29, 2024
This is the inverse "turn it back on again" intended to follow #206 . Long term we will use a different strategy but for now this works for some time
bkardell
added a commit
that referenced
this pull request
Jan 30, 2024
This is the inverse "turn it back on again" intended to follow #206 . Long term we will use a different strategy but for now this works for some time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems that this is currently building a > 2gb artifact as it just keeps growing, and what's happening is a fail to upload (or at least that is happening, maybe there's more too though) because that exceeds the limit for GH... I'd like to let it clean so we can verify if this is the whole issue, we can go back to true after. We'd need to rerun any existing prs.
I guess this is #47 basically, but I never noticed that one until today
Site preview: https://igalia.github.io/wpewebkit.org/bkardell-patch-3/