Hacked a way to link dashed line to Get Started #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! Personally this works for me, but I think others should chime in on whether the results are ok before we merge. |
mariospr
approved these changes
Sep 15, 2023
mariospr
added a commit
that referenced
this pull request
Sep 15, 2023
Closes #188 This is basically the fix implemented in [1], which was rendered useless after PR #189 [2] got merged, so this is a quick fix. [1] #191 [2] #189 Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2
mariospr
added a commit
that referenced
this pull request
Sep 15, 2023
Closes #188 This is basically the fix implemented in [1], which was rendered useless after PR #189 [2] got merged, so this is a quick fix. [1] #191 [2] #189 Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
This does cause the button to not look like a button on the Get Started page, but like all the other links. This was forced by the existing CSS, and may be desirable anyway, since it keeps the Call-To-Action button from looking like a Call To Action on the page it’s trying to get you to visit. If it must continue to look like a button, even on its own page, significant rewriting of the template script and CSS will probably be needed.
Site preview: https://igalia.github.io/wpewebkit.org/issue-188/