Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The broken line on the header doesn't point to "Get started" when visiting the "Get started" section #188

Closed
csaavedra opened this issue Jul 6, 2023 · 4 comments · Fixed by #191 or #192

Comments

@csaavedra
Copy link
Member

This is confusing. When opening "Get started", the arrow points to "Learn and discover" instead of the "Get started" button.

image

I would expect something like this (with proper styling for the button, of course):

image

@bkardell
Copy link
Member

bkardell commented Jul 6, 2023

@meyerweb

@meyerweb
Copy link
Member

meyerweb commented Jul 7, 2023

This is a hangover from the redesign, where “Get Started” was made a navbar CTA kind of late, and we decided not to move it to a new URL, and navbar highlighting is dependent on the directory in which a file resides. If I remember aright, at the time it was felt that highlighting of “Learn & Discover” flagged that “Get Started” was part of that section of the site. I don’t think changing the CTA button’s appearance is a good idea, but I’m also not married to the dashed line’s location. There might be a way to have it link up to the CTA button, if desired; I’d have to dig back into the CSS to be sure.

@csaavedra
Copy link
Member Author

I think one of the things that make the site confusing is this idea that "Get Started" has a toplevel button but it's also a subpage of "about" (which btw is actually called "Learn & Discover", another source of confusion -- see #173). With the rework of the contents of that page in #189 it would probably make sense to revisit the idea that this is a subsection of "about".

@csaavedra
Copy link
Member Author

@meyerweb Do you think you will have time to look into this any time soon?

mariospr added a commit that referenced this issue Sep 15, 2023
Closes #188

This is basically the fix implemented in [1], which was rendered
useless after PR #189 [2] got merged, so this is a quick fix.

[1] #191
[2] #189

Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2
mariospr added a commit that referenced this issue Sep 15, 2023
Closes #188

This is basically the fix implemented in [1], which was rendered
useless after PR #189 [2] got merged, so this is a quick fix.

[1] #191
[2] #189

Site preview: https://igalia.github.io/wpewebkit.org/issue-188-v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants