-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features to manipulate the SSL certificates errors at the WPEView level #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neodesys
force-pushed
the
feature/invalid-certs-management
branch
14 times, most recently
from
January 13, 2025 11:45
3c382e8
to
d8e249a
Compare
aperezdc
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some suggestions, but nothing that IMO should stop this from being merged. Please take a look before landing.
neodesys
force-pushed
the
feature/invalid-certs-management
branch
from
January 13, 2025 16:20
d8e249a
to
bd1c69f
Compare
- move all project and dependencies versions to a single file (gradle/libs.versions.toml) - unify quotes in build configurations - fixate the android sdk build tools version - in Github actions: unify the OS to Ubuntu latest LTS, use the default command line tools version for android-actions/setup-android@v3 and set the Android target SDK to the same value as in the build files
neodesys
force-pushed
the
feature/invalid-certs-management
branch
from
January 13, 2025 19:21
bd1c69f
to
37fa2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(gradle/libs.versions.toml)
command line tools version for android-actions/setup-android@v3 and
set the Android target SDK to the same value as in the build files