Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to manipulate the SSL certificates errors at the WPEView level #180

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

neodesys
Copy link
Collaborator

@neodesys neodesys commented Jan 9, 2025

  • Add "onReceivedSslError" callback to WPEViewClient
  • Add "setTLSErrorsPolicy" feature to the WPEView
  • Add "DisableWebSecurity" setting to WPESettings
  • Improve build configurations:
    • move all project and dependencies versions to a single file
      (gradle/libs.versions.toml)
    • unify quotes in build configurations
    • fixate the android sdk build tools version
    • in Github actions: unify the OS to Ubuntu latest LTS, use the default
      command line tools version for android-actions/setup-android@v3 and
      set the Android target SDK to the same value as in the build files

@neodesys neodesys requested review from aperezdc and mariospr January 9, 2025 19:58
@neodesys neodesys self-assigned this Jan 9, 2025
@zhani
Copy link
Contributor

zhani commented Jan 10, 2025

This seems to have a bit duplicated effort to #178 which already has a PR #179 in review. Maybe rebase and land this after #179

@neodesys
Copy link
Collaborator Author

This seems to have a bit duplicated effort to #178 which already has a PR #179 in review. Maybe rebase and land this after #179

I've reviewed and merged your PR. Don't worry for the effort, this is the Android Studio linter which has done all the work 😅

@neodesys neodesys force-pushed the feature/invalid-certs-management branch 14 times, most recently from 3c382e8 to d8e249a Compare January 13, 2025 11:45
Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some suggestions, but nothing that IMO should stop this from being merged. Please take a look before landing.

.github/workflows/build-latest-preview.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/check.yml Outdated Show resolved Hide resolved
.github/workflows/check.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/run-webdriver-tests.yml Outdated Show resolved Hide resolved
wpeview/src/main/cpp/Runtime/WKSettings.cpp Show resolved Hide resolved
wpeview/src/main/cpp/Runtime/WKWebView.cpp Outdated Show resolved Hide resolved
wpeview/src/main/cpp/Runtime/WKWebView.cpp Outdated Show resolved Hide resolved
wpeview/src/main/cpp/Runtime/WKWebView.cpp Show resolved Hide resolved
@neodesys neodesys force-pushed the feature/invalid-certs-management branch from d8e249a to bd1c69f Compare January 13, 2025 16:20
- move all project and dependencies versions to a single file
  (gradle/libs.versions.toml)
- unify quotes in build configurations
- fixate the android sdk build tools version
- in Github actions: unify the OS to Ubuntu latest LTS, use the default
  command line tools version for android-actions/setup-android@v3 and
  set the Android target SDK to the same value as in the build files
@neodesys neodesys force-pushed the feature/invalid-certs-management branch from bd1c69f to 37fa2d9 Compare January 13, 2025 19:21
@neodesys neodesys merged commit 41bab60 into main Jan 13, 2025
4 of 5 checks passed
@neodesys neodesys deleted the feature/invalid-certs-management branch January 13, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants