wkdev-enter: quiet mode and related options for scripts #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an optional --quiet flag for wkdev-enter that suppresses logging to stdout, so that scripts can be written that use wkdev-enter without pollution from wkdev logs. The _log_ function now calls the logger command that writes to journald. This is meant to help with troubleshooting scripts that use the quiet mode. This patch also adds the flags --no-tty and --no-interactive, which disable --tty and --interactive in podman exec respectively, and are of interest in scripts.
nikolaszimmermann
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an optional --quiet flag for wkdev-enter that suppresses logging to stdout, so that scripts can be written that use wkdev-enter without pollution from wkdev logs.
The log function now calls the logger command that writes to journald. This is meant to help with troubleshooting scripts that use the quiet mode.
This patch also adds the flags --no-tty and --no-interactive, which disable --tty and --interactive in podman exec respectively, and are of interest in scripts.