Use _log_ instead of echo for logging messages #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to disable logging messages with new --quiet options or to use syslog/journald in the future.
nikolaszimmermann
approved these changes
Oct 24, 2024
I tried, hopefully didn't miss any. |
ntrrgc
added a commit
to ntrrgc/webkit-container-sdk
that referenced
this pull request
Oct 25, 2024
I missed this file when working on Igalia#64 due to ripgrep excluding hidden files by default.
TingPing
pushed a commit
that referenced
this pull request
Oct 26, 2024
I missed this file when working on #64 due to ripgrep excluding hidden files by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to disable logging messages with new --quiet options or to use syslog/journald in the future.