Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysprof-47 (beta) support to wkdev-sdk. #38

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

nikolaszimmermann
Copy link
Member

The prerequisite is to have sysprof installed on the host system, so that the container is able to talk to it via d-bus.

If that works, sysprof-cli -- run-minibrowser works out-of-the-box.

@nikolaszimmermann nikolaszimmermann force-pushed the nzimmermann/add-sysprof-46-support branch from 58cf95d to 7d9239c Compare August 28, 2024 11:45
@nikolaszimmermann
Copy link
Member Author

I originally planned to use sysprof-46 stable release, and apply my patch to make polkit-agent optional on top of that (it landed in master, and there is no plan to make another sysprof 46 release that includes it). However that didn't work out. I need to pass "-Dpolkit_agent=disabled" as meson option to sysprof. That option doesn't exist in the 46.0 branch, only after applying my patch. Apparently jhbuild ran meson setup before applying the patches -- at least I couldn't get it to work. Since the GNOME 47 release is due soon, I think it's fine to stay at these beta releases (for e.g. libadwaita) for now, and update to the releases, once GNOME 47 is out.

@nikolaszimmermann nikolaszimmermann force-pushed the nzimmermann/add-sysprof-46-support branch 2 times, most recently from aa429a2 to 01f0690 Compare August 28, 2024 12:18
@TingPing
Copy link
Member

Unfortunately if a module uses a source from git it does not apply patches, only from tarballs. It's on my todo list to fix that some day.

Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LGTM.

@nikolaszimmermann
Copy link
Member Author

Unfortunately if a module uses a source from git it does not apply patches, only from tarballs. It's on my todo list to fix that some day.

Ah! Thanks for the explaination.

The prerequisite is to have sysprof installed on the host system,
so that the container is able to talk to it via d-bus.

If that works, `sysprof-cli -- run-minibrowser` works out-of-the-box.
@nikolaszimmermann nikolaszimmermann force-pushed the nzimmermann/add-sysprof-46-support branch from 01f0690 to 9f7f34b Compare August 29, 2024 15:40
@nikolaszimmermann nikolaszimmermann enabled auto-merge (squash) August 29, 2024 15:44
@nikolaszimmermann nikolaszimmermann merged commit e05637b into main Aug 29, 2024
2 checks passed
@nikolaszimmermann nikolaszimmermann deleted the nzimmermann/add-sysprof-46-support branch August 29, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants