-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysprof-47 (beta) support to wkdev-sdk. #38
Conversation
58cf95d
to
7d9239c
Compare
I originally planned to use sysprof-46 stable release, and apply my patch to make polkit-agent optional on top of that (it landed in master, and there is no plan to make another sysprof 46 release that includes it). However that didn't work out. I need to pass "-Dpolkit_agent=disabled" as meson option to sysprof. That option doesn't exist in the |
aa429a2
to
01f0690
Compare
Unfortunately if a module uses a source from git it does not apply patches, only from tarballs. It's on my todo list to fix that some day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, LGTM.
Ah! Thanks for the explaination. |
The prerequisite is to have sysprof installed on the host system, so that the container is able to talk to it via d-bus. If that works, `sysprof-cli -- run-minibrowser` works out-of-the-box.
01f0690
to
9f7f34b
Compare
The prerequisite is to have sysprof installed on the host system, so that the container is able to talk to it via d-bus.
If that works,
sysprof-cli -- run-minibrowser
works out-of-the-box.