Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List libsysprof-capture-4-dev for installation #36

Closed
wants to merge 1 commit into from

Conversation

aperezdc
Copy link
Member

WebKit uses libsysprof-capture by default to gather runtime profiling data. Currently developer builds use a bundled copy of the library, so provide it in the SDK container to allow switching to always preferring the system-installed copy.


This is needed before we can tackle https://bugs.webkit.org/show_bug.cgi?id=277627

WebKit uses libsysprof-capture by default to gather runtime profiling
data. Currently developer builds use a bundled copy of the library, so
provide it in the SDK container to allow switching to always preferring
the system-installed copy.
@aperezdc aperezdc added the wkdev image Relating to the contents of the image and the Containerfile label Aug 19, 2024
@aperezdc aperezdc self-assigned this Aug 19, 2024
@aperezdc
Copy link
Member Author

As @TingPing pointed out, images/wkdev_sdk/Containerfile calls into Tools/{wpe,gtk}/install-dependencies into the WebKit checkout, so adding the package to the lists used for those scripts would have it installed without needing this patch. Closing, and I will make the corresponding patch for WebKit instead.

@aperezdc aperezdc closed this Aug 19, 2024
@TingPing
Copy link
Member

Triggered a new build so it will be added to the image: https://github.com/Igalia/webkit-container-sdk/actions/runs/10202240105

@aperezdc aperezdc deleted the aperezdc/libsysprofcapture branch August 20, 2024 19:10
@aperezdc
Copy link
Member Author

Triggered a new build so it will be added to the image: https://github.com/Igalia/webkit-container-sdk/actions/runs/10202240105

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wkdev image Relating to the contents of the image and the Containerfile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants