Improve wkdev-enter usability #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raise timeout from 10s -> 20s per retry (the jhbuild directory permission step takes a long time, depending on overlayfs performance). - Actually honor the max-retries parameter - due to an oversight it always stopped at 10 retries. - Document the failure case: how to investigate: podman logs -f <container_name>. Include that hint in the error message.
nikolaszimmermann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise timeout from 10s -> 20s per retry (the jhbuild directory permission step takes a long time, depending on overlayfs performance).
Actually honor the max-retries parameter - due to an oversight it always stopped at 10 retries.
Document the failure case: how to investigate: podman logs -f <container_name>. Include that hint in the error message.