Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create template modal #802

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix create template modal #802

merged 2 commits into from
Feb 20, 2024

Conversation

negreirosleo
Copy link
Contributor

This PR fix the typescript error in the SaveTemplate form.

Screencast.from.2024-02-19.15-24-59.webm

This removed the useFormStatus import error
Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -34,6 +34,16 @@ export const SaveTemplateModal = ({ task }: SaveAsTemplateProps) => {
<Sheet
variant="outlined"
component="form"
action={async (formData: FormData) => {
console.log('test')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit :)

Suggested change
console.log('test')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you saw nothing 👀

Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you tried running npm run build to make sure that this will now work during build? I had changed this initially in order to solve the build errors related to the useFormStatus.

@negreirosleo
Copy link
Contributor Author

@dmtrek14 the build is working! (I forgot to add the @types/react update on the commit earlier)

@negreirosleo
Copy link
Contributor Author

image

Building 🙏

@negreirosleo negreirosleo merged commit 7896b5e into main Feb 20, 2024
2 checks passed
@negreirosleo negreirosleo deleted the fix-create-template branch February 20, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants