-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create template modal #802
Conversation
This removed the useFormStatus import error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -34,6 +34,16 @@ export const SaveTemplateModal = ({ task }: SaveAsTemplateProps) => { | |||
<Sheet | |||
variant="outlined" | |||
component="form" | |||
action={async (formData: FormData) => { | |||
console.log('test') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit :)
console.log('test') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you saw nothing 👀
a3b24bd
to
020ae51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have you tried running npm run build
to make sure that this will now work during build? I had changed this initially in order to solve the build errors related to the useFormStatus.
020ae51
to
4c7b6ec
Compare
@dmtrek14 the build is working! (I forgot to add the @types/react update on the commit earlier) |
This PR fix the typescript error in the SaveTemplate form.
Screencast.from.2024-02-19.15-24-59.webm