Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable leave projects to everyone #782

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

anarute
Copy link
Member

@anarute anarute commented Jan 19, 2024

Instead of having to manually assign everyone to all the leave projects, return them when fetching user's projects.
Also check if they can log time to a project before creating a task.

@anarute anarute requested a review from dmtrek14 January 19, 2024 16:56
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on this end. Thanks for the patch.

@anarute anarute force-pushed the enable-leave-projects-to-everyone branch from e9f9a39 to c12e780 Compare January 19, 2024 17:19
Make sure the user is able to log time a project before creating
a task. Even though we check in the front end is possible people who
use scripts to log time to any project, so we need to check here
as well.
People should be able to log time to projects they are assigned to
and also to any project with the type leave.
@anarute anarute force-pushed the enable-leave-projects-to-everyone branch from c12e780 to 294a68d Compare January 19, 2024 17:37
@anarute anarute merged commit 73c090d into main Jan 19, 2024
2 checks passed
@anarute anarute deleted the enable-leave-projects-to-everyone branch January 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants