db: Add utility functions #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrek14
force-pushed
the
summary-panel
branch
from
44c1633 to
f923597
Compare
anarute
approved these changes
Jan 11, 2024
Comment on lines
40
to
41
| * yearly_vacation_hours | ||
| * (capacity * 5 / company_fte_weekly::float) |
There was a problem hiding this comment.
Nit: I think the indentation is a bit off for these lines, it should be one tab more?
There was a problem hiding this comment.
Good catch - fixing!
- Add functions to be used in calculation of yearly_expected_and_vacation for work summary
dmtrek14
force-pushed
the
summary-panel
branch
from
f923597 to
14e5fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each function is commented with purpose and any "gotchas" (such as needing to add a day in a date diff because one end isn't included). I decided to put the functions in their own folder because we are starting to get enough db infra to justify keeping track of these better. Eventually, I will also move the archiving function into this folder, as well. Having functions in their own files will allow us to more easily keep track of changes to them in source control.