Create template modal #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done to use the server actions without having to use the experimental flag, it was release in v14 and since we are using next I think it is worth using the features that are driving the framework development
This class is created to improve the error handling through the code and t make it easier to create new errors
This modal contains the form to save a task as a template
This SubmitButton is a regular button but it uses the useFormStatus hook to get the "pending" state from form to know if it should or shouldn't be disabled.
This commit doubles down on the next js capabilities, by using new the server actions it makes a lot of states tracking and useEffects unnecessary thus making us write less code to have the same features
This commit changes the structure for the apiClient dependecy injection, it exports a makeCreateTemplate function that receives the apiClient as prop and return the createTemplate function, I made this change because I think this pattern is easier to follow through the application. Also I intend to change the other api calls in future pr's.
The Jest transformer breaks with some server libs that are used by the server actions, this globally mocks the next-auth session so we don't have to worry about it ever again.
negreirosleo
force-pushed
the
create-template-modal
branch
from
fdbc4bf to
99fbed5
Compare
anarute
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create save task as template modal.
Instead of having controlled inputs and react query I tried using the new server actions from next js v14 to submit the form. I like the result of it, it save us from writing more code to track the fetch states, and having to use more hooks.
Screencast.from.2023-12-29.18-23-09.webm