Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use some instead of includes to check task types #743

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Use some instead of includes to check task types #743

merged 1 commit into from
Dec 12, 2023

Conversation

anarute
Copy link
Member

@anarute anarute commented Dec 12, 2023

Includes only works for flat arrays, we want the method some in this case.

@anarute
Use some instead of includes to check task types
9cc08c0 
Includes only works for flat arrays, we want the method `some` in
this case.
@anarute anarute requested a review from dmtrek14 December 12, 2023 14:23
dmtrek14
dmtrek14 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anarute anarute merged commit e20e786 into main Dec 12, 2023
2 checks passed
@anarute anarute deleted the fix-ttype-check branch December 12, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrek14 dmtrek14 dmtrek14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anarute @dmtrek14