Add PUT endpoint for tasks #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anarute I put this one in draft status to get some feedback. The validate_task method got lengthier here and I think I could use another pair of eyes. Instead of a full object merge, I decided to validate an updated task only if the properties we validate (start, end, project_id, date) are different from the task in the db. If someone only wants to update the description or story, is it necessary to revalidate everything? I went with 'no' but am open to going the other way. |
anarute
reviewed
Oct 11, 2023
dmtrek14
force-pushed
the
task-put-endpoint
branch
from
2564b6b to
95ebc0d
Compare
- Add the endpoint - Add TemplateUpdate schema - Add a simple get method to tasks service so we can check for existing task - Small updates to endpoint docs to provide more clarity - Small update to regex for start and end time to ensure times are between 00:00 and 23:59 - Update validation for overlapping tasks
dmtrek14
force-pushed
the
task-put-endpoint
branch
from
95ebc0d to
e020baa
Compare
anarute
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #692
The validation updates for update were a bit extensive. Since it should be possible for someone to send a PUT request with only the task_id and the properties they want to update, we needed several additional checks to ensure the validation would work with a partial object. Mostly, we need to ensure the required properties (user_id, project_id, end, init, date) are on the object to be validated or else the validation fails.