-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create task form #680
Create task form #680
Conversation
We will be using JoyUI theme for now so its safe to delete this
This lib is being installed to facilitate the communication with the API and the state management for it.
I'm tyring to test it locally and I keep being redirected to /web/v2 when I try to access /web/v2/tasks |
@anarute I also keep getting redirected, but I tried commenting out the A few small things: The clear button does not seem to clear the task description. On mobile, the 'More actions' and the buttons are a bit squished on one line, so perhaps the buttons should flow underneath the dropdown at small screen sizes. |
I agree with Danielle's comment and would also add that I think we should make the dropdowns have autocomplete feature from the beginning, as keyboard navigation was the number one request from our users. |
It seems the autocomplete clean up is not working well, once I select a value I cannot remove it: Screencast.from.2023-09-28.13-51-31.webm |
I think for this PR, adding the To and From fields should be enough, and then the timer, template and data fetching can be in new PRs, what do you think @dmtrek14 ? |
I agree. It will help separate the work out a little better. We expect the timer to be a little complex and it makes sense for it to be its own PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thank you!
* Remove NextJs default styles We will be using JoyUI theme for now so its safe to delete this * Add ReactQuery to project This lib is being installed to facilitate the communication with the API and the state management for it. * Create hooks to fetch projects and tasktypes * Create Form page * Add reset form action * Switch Select for Autocomplete * Refactor useForm types * Add loading to select * Improve Buttons positioning * Fix Autocomplete clear * Select Option on autocomplete with Tab * Adjust Task to TaskType * Reorder TaskForm fields
Changes
This PR creates the new Task form, it:
useForm
hook to manage the form stateIn the Adobe Layout the form items have 40px of height, but I changed it to 56px to accommodate the floating label.
Screenshots