Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpewebkit, webkitgtk: Bump to version 2.46.4 #522

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

psaavedra
Copy link
Member

WebKitGTK changes:

  • Improve memory consumption and performance of Canvas getImageData.
  • Fix preserve-3D intersection rendering.
  • Fix video dimensions since GStreamer 1.24.9.
  • Fix the HTTP-based remote Web Inspector not loading in Chromium.
  • Fix content filters not working on about:blank iframes.
  • Fix several crashes and rendering issues.

WPEWebKit 2.46.4 Changes:

  • Improve memory consumption and performance of Canvas getImageData().
  • Improve reliability and latency of audio/video MediaStream pipeplines.
  • Improve detection of accelerated H.264 decoders.
  • Add WebM audio capture bitrate configuration with GStreamer 1.24.9 and newer.
  • Fix multi-touch input event handling.
  • Fix getDisplayMedia() buffer format negotiation with PipeWire.
  • Fix wrong video dimensions with GStreamer 1.34.9 and newer.
  • Fix intersection and filter rendering for scenes with CSS transform-tyle: preserve-3d.
  • Fix the HTTP-based remote Web Inspector not loading in Chromium.
  • Fix Office 365 using an User-Agent quirk.
  • Fix content filters not working on about:blank iframes.
  • Fix logging in the memory pressure handler monitor.
  • Fix the JSCOnly build with the GLib event loop enabled.
  • Fix hole-punching media player when using fixed HTML body position.
  • Fix the build with GCC 12.x when libwebrtc support is enabled.
  • Fix the build with libsoup2.
  • Fix several crashes and rendering issues.

Release Notes:

Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to include this revert as well because it fixes an important performance regression, see WebKit bug #283820 for the details.

The rest of the changes look fine 👌🏼

Changes:

* Improve memory consumption and performance of Canvas getImageData().
* Improve reliability and latency of audio/video MediaStream pipeplines.
* Improve detection of accelerated H.264 decoders.
* Add WebM audio capture bitrate configuration with GStreamer 1.24.9 and newer.
* Fix multi-touch input event handling.
* Fix getDisplayMedia() buffer format negotiation with PipeWire.
* Fix wrong video dimensions with GStreamer 1.34.9 and newer.
* Fix intersection and filter rendering for scenes with CSS transform-tyle: preserve-3d.
* Fix the HTTP-based remote Web Inspector not loading in Chromium.
* Fix Office 365 using an User-Agent quirk.
* Fix content filters not working on about:blank iframes.
* Fix logging in the memory pressure handler monitor.
* Fix the JSCOnly build with the GLib event loop enabled.
* Fix hole-punching media player when using fixed HTML body position.
* Fix the build with GCC 12.x when libwebrtc support is enabled.
* Fix the build with libsoup2.
* Fix several crashes and rendering issues.

Patches:

* Add Build fixes for gbm disabled and release logs disabled
  * Upstream-Status: Backport [https://commits.webkit.org/287124@main]
* REGRESSION(286605@main): [WPE] Massive performance regression on postercircle
  * Upstream-Status: Submitted [WebKit/WebKit@7d076f9]
Changes:

* Improve memory consumption and performance of Canvas getImageData.
* Fix preserve-3D intersection rendering.
* Fix video dimensions since GStreamer 1.24.9.
* Fix the HTTP-based remote Web Inspector not loading in Chromium.
* Fix content filters not working on about:blank iframes.
* Fix several crashes and rendering issues.

Patches:

* Add Build fixes for gbm disabled and release logs disabled
  * Upstream-Status: Backport [https://commits.webkit.org/287124@main]

Release Notes:

* https://webkitgtk.org/2024/11/27/webkitgtk2.46.4-released.html
The support of this interface is dropped in bitbake:

    cooker: Drop support for BB_DANGLINGAPPENDS_WARNONLY
    DANGLINGAPPENDS_WARNONLY is a very poorly designed interface and
    is commonly abused. The challenge is that once it is set, by any
    layer, it applies everywhere.

    Some layers rely on this to get notification they need to update
    bbappend files and having the behaviour change from inclusion of an
    antisocial layer is not good.

    In addition, showing warnings as an accepted thing on the console
    devalues them and trains the user to ignore them. I want to steer us
    away from this mindset.

    We could extend the functionality and make it apply only to certain
    layers, or only to certain appends but then we've basically re-invented
    BBMASK.

    Given all the above, we should drop support for BB_DANGLINGAPPENDS_WARNONLY
    and direct anyone with issues to BBMASK instead.

    https://lists.openembedded.org/g/openembedded-architecture/message/2029

    [YOCTO #14870]

    Signed-off-by: Richard Purdie <[email protected]>

Related-To: https://git.openembedded.org/bitbake/commit/?id=fca9c9e3cb6f8e9f99bf51dc5e8a8d83f4c84c69
Copy link
Member

@aperezdc aperezdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM 👍🏼

@psaavedra
Copy link
Member Author

Job failed for Walnascar due to a recent icu update (https://git.openembedded.org/openembedded-core/commit/meta/recipes-support/icu?id=ef2bd18dd1db7e5f01db76889933bfdbb5415aaf). Fails on this job are acceptable since Walnascar is not yet released.

@psaavedra
Copy link
Member Author

Job failed for Walnascar due to a recent icu update (https://git.openembedded.org/openembedded-core/commit/meta/recipes-support/icu?id=ef2bd18dd1db7e5f01db76889933bfdbb5415aaf). Fails on this job are acceptable since Walnascar is not yet released.

Created issue #523.

@psaavedra psaavedra merged commit 3c7ce76 into main Dec 6, 2024
11 of 12 checks passed
@psaavedra psaavedra deleted the psaavedra/2.46.4 branch December 6, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants