wpebackend-rdk: Bump up version to 1.20210402 #279
Conversation
Signed-off-by: Pablo Saavedra <[email protected]>
| SRCREV = "196f75360b8643b119d8d96208d914998e5d4fc9" | ||
|
|
||
| PV = "1.20210402" |
There was a problem hiding this comment.
Too bad upstream does not seem to have interest in making releases—I've filed WebPlatformForEmbedded/WPEBackend-rdk#35 ~2 years ago to no avail. Using date-coded versions is the best we can do here for now 🤷🏼
| PACKAGECONFIG[libinput] = "-DUSE_INPUT_LIBINPUT=ON,-DUSE_INPUT_LIBINPUT=OFF,libinput," | ||
| PACKAGECONFIG[libinput-udev] = "-DUSE_INPUT_UDEV=ON,-DUSE_INPUT_UDEV=OFF,libinput eudev," |
There was a problem hiding this comment.
Certain backends require usage of libinput to be able to receive input events. For example the src/viv-imx6/view-backend.cpp file uses the LibinputServer unconditionally, so passing -DUSE_INPUT_LIBINPUT=OFF will make the build fail. It looks to me that this kind of cases should be taken into account here.
As for -DUSE_INPUT_UDEV= option, what I would do is always enable it if libudev is being built. The amount of code added to the backend is very small, and libput will fallback to enumerate itself devices from /dev/input if udev is not available at runtime, so there is hardly a reason to have a build option for this. That being said, I have no idea how complicated to do the “enable option X if package Y is being built” with Bitbake, so if it's hard feel free to ignore the suggestion.
|
This PR is stale because it has been open 90 days with no activity. |
|
I have sent a new PR to update this backend to a newer version that obsoletes this PR (I think). |
|
ok |
SSIA