ssldir from puppet agent

[TheFlyingCorpse]

This fixes the dependence on having the same puppet version (3 vs 4) on all agents AND puppetserver.
With this you can have legacy agents (3.7 that I have tested) with puppetserver 4.x.

[TheFlyingCorpse]

This commit implies that PR #196 is accepted.

[zachfi]

This is a poor default here because it will retrieve the master's ssldir, and not the agents. This would only work in an environment where the master and the agent are the same operating system. This should be at least overridable by the user as a parameter on a class, which is not possible given the current implementation.

[TheFlyingCorpse]

The fix in this is actually what you describe, it will use the agents
ssldir. Currently it does not use it, it uses the masters ssldir!

On 25 April 2016 at 04:01, Zach Leslie [email protected] wrote:

In manifests/params.pp
voxpupuli/puppet-icinga2#197 (comment):

• if $::icinga2::varprefix {
• $varprefix = $::icinga2::varprefix
• }
• elsif $::icinga2::dirprefix {
• $varprefix = "${::icinga2::dirprefix}/var"
• }
• else {
• $varprefix = '/var'
• }

• if $::i2_puppet_ssldir {
• $puppetssldir = $::i2_puppet_ssldir
• }
• else {
• $puppetssldir = $::settings::ssldir

This is a poor default here because it will retrieve the master's ssldir,
and not the agents. This would only work in an environment where the master
and the agent are the same operating system. This should be at least
overridable by the user as a parameter on a class, which is not possible
given the current implementation.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Icinga/puppet-icinga2/pull/197/files/72b080952e942cf740863127e7ddddc841a2ef41#r60857430

[TheFlyingCorpse]

Will update this as often as I can based on the updates to PR 196, for now I need at least one more fix to 196 before this will be updated again.

[Reamer]

👍 also tested in my environment. Thank you.

[TheFlyingCorpse]

Rebased