Remove vendor dependency #5048
Merged
Remove vendor dependency #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests should still run. What's the strategy? Require |
raviks789
force-pushed
the
remove-vendor-dependency
branch
2 times, most recently
from
5f8deaa
to
7dbe347
Compare
raviks789
force-pushed
the
remove-vendor-dependency
branch
from
7dbe347
to
f776cf0
Compare
|
@raviks789 Please rebase. |
raviks789
force-pushed
the
remove-vendor-dependency
branch
from
f776cf0
to
1f7bc87
Compare
lippserd
previously approved these changes
Jul 17, 2023
nilmerg
previously approved these changes
Jul 17, 2023
The vendor dependencies will be moved to `composer.json` in `icinga-php-thirdparty`.
Also avoid autoloading vendor.
nilmerg
force-pushed
the
remove-vendor-dependency
branch
3 times, most recently
from
10d9104
to
e95a3f1
Compare
Since the vendor libraries are moved to `icinga-php-thirdparty`. The php test workflow needs to be updated, so that these libraries could be found during the test run.
nilmerg
force-pushed
the
remove-vendor-dependency
branch
from
70e38f0
to
0a6db98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries in vendor directory has been moved to
composer.jsonfile in icinga-php-thirdparty.Blocked By
Icinga/icinga-php-thirdparty#11
closes #5007