Use sync/atomic#Pointer instead of our own wrapper
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
force-pushed
the
use-sync-atomic
branch
from
f3ff6e1
to
76e7632
Compare
Al2Klimov
reviewed
Sep 19, 2024
| @@ -121,7 +121,8 @@ func (h *HA) Takeover() chan string { | |||
|
|
|||
| // State returns the status quo. | |||
| func (h *HA) State() (responsibleTsMilli int64, responsible, otherResponsible bool) { | |||
| state, _ := h.state.Load() | |||
| state := h.state.Load() | |||
|
|
|||
There was a problem hiding this comment.
This has been a zero value if uninitialized, now it's a nil ptr in this case. Now we have to make sure HA#State() don't get a nil ptr.
| @@ -428,7 +429,7 @@ func (h *HA) realize( | |||
|
|
|||
| h.signalTakeover(takeover) | |||
| } else if otherResponsible { | |||
| if state, _ := h.state.Load(); !state.otherResponsible { | |||
| if state := h.state.Load(); !state.otherResponsible { | |||
There was a problem hiding this comment.
As we're now loading by-ref, state.otherResponsible = true below affects all readers. But this shouldn't be too bad as that's just a bool and we're storing it anyway right away.
lippserd
force-pushed
the
use-sync-atomic
branch
from
76e7632
to
9125c35
Compare
yhabteab
reviewed
Oct 22, 2024
yhabteab
previously approved these changes
Oct 22, 2024
Go 1.19 introduced `sync/atomic#Pointer` among other things, so we no longer need to use the Atomic wrapper from our Icinga Go library.
Go 1.19 introduced `sync/atomic#Pointer` among other things, so we no longer need to use the Atomic wrapper from our Icinga Go library.
lippserd
force-pushed
the
use-sync-atomic
branch
from
9125c35
to
7cf54c1
Compare
lippserd
changed the title
HA: Use sync/atomic#Pointer instead of our own wrappersync/atomic#Pointer instead of our own wrapper
|
@Al2Klimov @yhabteab I also changed the type in |
yhabteab
previously approved these changes
Oct 24, 2024
Return `atomic.pointer`, so that initialisation is not the responsibility of another package.
|
@yhabteab I'm sorry, I had to push another change 😆. |
Al2Klimov
approved these changes
Oct 24, 2024
yhabteab
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.19 introduced
sync/atomic#Pointeramong other things, so we no longer need to use the Atomic wrapper from our Icinga Go library.