-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library split #654
Closed
Closed
Library split #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
force-pushed
the
library-split
branch
7 times, most recently
from
October 10, 2023 13:37
0ecfe6f
to
6bcaaac
Compare
lippserd
force-pushed
the
library-split
branch
2 times, most recently
from
November 21, 2023 06:17
788f43e
to
04648f4
Compare
This prevents import cycles because the `database` package uses the `types` packages.
Otherwise we would have to move the `Equaler` interface to the `types` package, which is pretty useless for a single use case.
lippserd
force-pushed
the
library-split
branch
from
November 21, 2023 20:03
04648f4
to
0b226ee
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.