Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger time based escalations #68

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Trigger time based escalations #68

merged 12 commits into from
Nov 20, 2023

Conversation

yhabteab
Copy link
Member

fixes #63

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label May 12, 2023
@yhabteab yhabteab added the bug Something isn't working label May 12, 2023
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch 4 times, most recently from bad8439 to 903a140 Compare May 16, 2023 09:14
@yhabteab yhabteab force-pushed the restructure-codes branch 4 times, most recently from 371636c to 6bddc85 Compare May 22, 2023 08:46
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from 903a140 to b5bcddf Compare May 22, 2023 09:12
julianbrost
julianbrost reviewed May 22, 2023
View reviewed changes
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First few comments only, i.e. those until I noticed that I should probably look at #67 first.

internal/filter/types.go Outdated Show resolved Hide resolved
internal/rule/condition.go Outdated Show resolved Hide resolved
internal/object/db_types.go Outdated Show resolved Hide resolved
internal/object/db_types.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from b5bcddf to 8e29178 Compare May 22, 2023 13:20
@yhabteab yhabteab changed the base branch from restructure-codes to use-sqlx-tx May 22, 2023 13:20
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from 8e29178 to fcfb235 Compare May 22, 2023 13:41
@yhabteab yhabteab force-pushed the use-sqlx-tx branch 2 times, most recently from 72f0f89 to c48835b Compare May 23, 2023 07:35
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch 2 times, most recently from 9150312 to fcfb235 Compare May 23, 2023 07:47
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from fcfb235 to bee18d4 Compare May 23, 2023 07:58
@yhabteab yhabteab force-pushed the use-sqlx-tx branch 2 times, most recently from 3d14c51 to f44c4b6 Compare May 25, 2023 12:32
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from bee18d4 to f2cb44c Compare May 25, 2023 14:18
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from f2cb44c to f62d32b Compare May 25, 2023 14:38
@yhabteab yhabteab force-pushed the use-sqlx-tx branch 2 times, most recently from 115a60a to 24b6dd0 Compare May 26, 2023 15:21
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from f62d32b to 14f0014 Compare May 26, 2023 15:27
julianbrost
julianbrost reviewed Aug 10, 2023
View reviewed changes
internal/incident/incidents.go Outdated Show resolved Hide resolved
internal/incident/incidents.go Outdated Show resolved Hide resolved
internal/incident/incident.go Outdated Show resolved Hide resolved
internal/incident/incident.go Outdated Show resolved Hide resolved
internal/rule/condition.go Outdated Show resolved Hide resolved
internal/incident/incident.go Outdated Show resolved Hide resolved
julianbrost
julianbrost requested changes Nov 9, 2023
View reviewed changes
internal/filter/types.go Outdated Show resolved Hide resolved
internal/rule/condition.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch 2 times, most recently from a08d873 to 28ad757 Compare November 14, 2023 15:31
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from 28ad757 to d127963 Compare November 14, 2023 16:40
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from d127963 to 1b8b219 Compare November 15, 2023 16:35
julianbrost
julianbrost requested changes Nov 16, 2023
View reviewed changes
internal/rule/condition.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from 1b8b219 to bc6536e Compare November 16, 2023 13:58
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from bc6536e to bbb9edc Compare November 16, 2023 14:06
julianbrost
julianbrost requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One message in the event is incorrect. Apart from that, this PR should be good to go.

internal/incident/incident.go Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from b8f9924 to e45cc3e Compare November 17, 2023 08:39
@yhabteab
Set severity field of the dummy events
f45fe6f 
Otherwise, the notification subject is looking odd, since this field is
used to build the notification messages.
@yhabteab yhabteab force-pushed the trigger-time-based-escalations branch from e45cc3e to f45fe6f Compare November 17, 2023 08:40
@julianbrost julianbrost merged commit 1acb259 into main Nov 20, 2023
3 checks passed
@julianbrost julianbrost deleted the trigger-time-based-escalations branch November 20, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees

@yhabteab yhabteab

Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger time-based escalations without external events
2 participants
@yhabteab @julianbrost