Skip to content

Commit

Permalink
temp update
Browse files Browse the repository at this point in the history
Signed-off-by: Iceber Gu <[email protected]>
  • Loading branch information
Iceber committed Sep 23, 2022
1 parent 849eba6 commit 601df00
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 17 deletions.
34 changes: 17 additions & 17 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,47 +9,47 @@ This doc outlines the various responsibilities of contributor roles in Clutserpe
|Reviewer|Review contributions from other members|[OWNERS](#submodel-and-owners-files) file reviewer entry|
|Approver|Contributions acceptance approval|[OWNERS](#submodel-and-owners-files) file approver entry|

### Member
## Member
Members are continuously active contributors in the community. They can have issues and PRs assigned to them.
Members are expected to remain active contributors to the community.

**Defined by**: Member of the Clusterpedia GitHub organization

#### Requirements
### Requirements
* Enabled two-factor authentication on their GitHub account
* Have made multiple contributions to the project or community. Contribution may include, but is not limited to:
* Actively contributing to 1 or more subprojects. At least **three** PR must be merged.
* Published several different articles or speeches about Clusterpedia.
* **Actively contributing to 1 or more subprojects. At least three PR must be merged.**
* **Published several different articles or speeches about Clusterpedia.**
* [Open an membership issue](https://github.com/clusterpedia-io/clusterpedia/issues/new?assignees=Iceber&labels=kind%2Fmembership&template=membership-request.md&title=%5BMEMBERSHIP+REQUEST%5D+New+Member+of+Clusterpedia)
* Make sure that the list of contributions included is representative of your work on the project.

#### Responsibilities and privileges
### Responsibilities and privileges
* Responsive to issues and PRs assigned to them
* Members can do `/lgtm` on open PRs.
* They can be assigned to issues and PRs, and people can ask members for reviews with a `/cc @username.`

**Note**: members who frequently contribute code are expected to proactively perform code reviews and work towards becoming a primary reviewer for the [submodel](#submodel-and-owners-files) that they are active in.

### Reviewer
## Reviewer
Reviewers are able to review code for quality and correctness on the [submodel](#submodel-and-owners-files).
They are knowledgeable about both the codebase and software engineering principles.

**Defined by**: reviewers entry in an [OWNERS](#submodel-and-owners-files) file.

Reviewer status is scoped to a part of the codebase.

#### Requirements
### Requirements
The following apply to the part of codebase for which one would be a reviewer in an [OWNERS](#submodel-and-owners-files) file (for repos using the bot).
* member for at least 1 months
* Primary reviewer for at least 3 PRs to the codebase
* Reviewed or merged at least 10 substantial PRs to the codebase
* **member for at least 1 months**
* **Primary reviewer for at least 3 PRs to the codebase**
* **Reviewed or merged at least 10 substantial PRs to the codebase**
* Knowledgeable about the codebase
* Sponsored by a [submodel](#submodel-and-owners-files) approver
* With no objections from other approvers
* Done through PR to update the [OWNERS](#submodel-and-owners-files) file
* May either self-nominate, be nominated by an approver in this [submodel](#submodel-and-owners-files).

#### Responsibilities and privileges
### Responsibilities and privileges
The following apply to the part of codebase for which one would be a reviewer in an [OWNERS](#submodel-and-owners-files) file (for repos using the bot).

* Code reviewer status may be a precondition to accepting large code contributions
Expand All @@ -60,23 +60,23 @@ The following apply to the part of codebase for which one would be a reviewer in
* Assigned PRs to review related to [submodel](#submodel-and-owners-files) of expertise
* Assigned test bugs related to [submodel](#submodel-and-owners-files) of expertise

### Approver
## Approver
Code approvers are able to both review and approve code contributions. While code review is focused on code quality and correctness, approval is focused on holistic acceptance of a contribution including: backwards / forwards compatibility, adhering to API and flag conventions, subtle performance and correctness issues, interactions with other parts of the system, etc.

**Defined by**: approvers entry in an [OWNERS](#submodel-and-owners-files) file

#### Requirements
### Requirements
The following apply to the part of codebase for which one would be an approver in an [OWNERS](#submodel-and-owners-files) file (for repos using the bot).
* Reviewer of the codebase for at least 2 months
* Primary reviewer for at least 10 substantial PRs to the codebase
* Reviewed or merged at least 30 PRs to the codebase
* **Reviewer of the codebase for at least 2 months**
* **Primary reviewer for at least 10 substantial PRs to the codebase**
* **Reviewed or merged at least 30 PRs to the codebase**
* Nominated by a maintainer
* With no objections from other maintainers
* Done through PR to update the [OWNERS](#submodel-and-owners-files) file

**If you add a new submodule, then you can apply to be the Approver for that module, and the core participants of that module can be nominated by you as Reviewer**

#### Responsibilities and privileges
### Responsibilities and privileges
The following apply to the part of codebase for which one would be an approver in an [OWNERS](#submodel-and-owners-files) file (for repos using the bot).

* Approver status may be a precondition to accepting large code contributions
Expand Down
4 changes: 4 additions & 0 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# consistent with MAINTAINERS.md
approvers:
- Iceber
- calvin0327

0 comments on commit 601df00

Please sign in to comment.