change from json_decode to response->json()

Iankumu · May 17, 2024 · c9c4015 · c9c4015
1 parent 3a24143
commit c9c4015
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 15 deletions.
diff --git a/app/Http/Controllers/MPESAB2CController.php b/app/Http/Controllers/MPESAB2CController.php
@@ -22,7 +22,10 @@ public function simulate(Request $request)
 
         $response = Mpesa::b2c($phoneno, $command, $amount, $remarks);
 
-        $result = json_decode((string)$response);
+        // $result = json_decode((string)$response);
+
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
 
         return Inertia::render('Payments/Partials/B2C', [
             'response' => $result,

diff --git a/app/Http/Controllers/MPESAC2BController.php b/app/Http/Controllers/MPESAC2BController.php
@@ -16,7 +16,10 @@ public function registerURLS(Request $request)
     {
         $shortcode = $request->input('shortcode');
         $response = Mpesa::c2bregisterURLS($shortcode);
-        $result = json_decode((string)$response, true);
+        // $result = json_decode((string)$response, true);
+
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
 
         return Inertia::render('Payments/Partials/C2B', [
             'response' => $result,

diff --git a/app/Http/Controllers/MpesaController.php b/app/Http/Controllers/MpesaController.php
@@ -45,12 +45,15 @@ public function simulate_balance(Request $request)
         $shortcode = $request->input('shortcode');
         $identifier = $request->input('identiertype');
         $remarks = $request->input('remarks');
-        $response=Mpesa::accountBalance($shortcode,$identifier,$remarks);
+        $response = Mpesa::accountBalance($shortcode, $identifier, $remarks);
 
-        $result = json_decode((string)$response);
+        // $result = json_decode((string)$response);
 
-        return Inertia::render('Payments/Partials/AccountBalance',[
-            'response'=>$result
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
+
+        return Inertia::render('Payments/Partials/AccountBalance', [
+            'response' => $result
         ]);
     }
     public function simulate_status(Request $request)
@@ -59,12 +62,15 @@ public function simulate_status(Request $request)
         $identifier = $request->input('identiertype');
         $transactionid = $request->input('transactionid');
         $remarks = $request->input('remarks');
-        $response=Mpesa::transactionStatus($shortcode,$transactionid,$identifier,$remarks);
+        $response = Mpesa::transactionStatus($shortcode, $transactionid, $identifier, $remarks);
+
+        // $result = json_decode((string)$response);
 
-        $result = json_decode((string)$response);
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
 
-        return Inertia::render('Payments/Partials/TransactionStatus',[
-            'response'=>$result
+        return Inertia::render('Payments/Partials/TransactionStatus', [
+            'response' => $result
         ]);
     }
     public function simulate_reversals(Request $request)
@@ -73,12 +79,15 @@ public function simulate_reversals(Request $request)
         $transactionid = $request->input('transactionid');
         $amount = $request->input('amount');
         $remarks = $request->input('remarks');
-        $response=Mpesa::reversal($shortcode,$transactionid,$amount,$remarks);
+        $response = Mpesa::reversal($shortcode, $transactionid, $amount, $remarks);
+
+        // $result = json_decode((string)$response);
 
-        $result = json_decode((string)$response);
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
 
-        return Inertia::render('Payments/Partials/Reversals',[
-            'response'=>$result
+        return Inertia::render('Payments/Partials/Reversals', [
+            'response' => $result
         ]);
     }
 

diff --git a/app/Http/Controllers/MpesaSTKPUSHController.php b/app/Http/Controllers/MpesaSTKPUSHController.php
@@ -25,7 +25,10 @@ public function STKPush(Request $request)
 
 
         $response = Mpesa::stkpush($phoneno, $amount, $account_number);
-        $result = json_decode((string)$response, true);
+        // $result = json_decode((string)$response, true);
+
+        /** @var \Illuminate\Http\Client\Response $response */
+        $result = $response->json();
 
         if (!is_null($result)) {
             MpesaSTK::create([