Skip to content

Commit

Permalink
Wallening [IDB IGNORE] [MDB IGNORE] (tgstation#85491)
Browse files Browse the repository at this point in the history
## What's going on here

Kept you waitin huh!

This pr resprites most all walls, windows and other "wall adjacent"
things to a 3/4th perspective, technical term is "tall" walls (we are
very smart).

If you're trying to understand the technical details here, much of the
"rendering tech" is built off the idea of split-vis. Basically, split a
sprite up and render it on adjacent turfs, to prevent seeing "through"
walls/doors, and to support seeing "edges" without actually seeing the
atom itself.

Most of the rest of it is pipelining done to accommodate how icons are
cut.

## Path To Merge

Almost* all sprites and code is done at this point. 
There are some things missing both on and off the bounty list, but that
will be the case forever unless we force upstream (you guys) to stop
adding new shit that doesn't fit the style.
I plan on accepting and integrating prs to the current working repo
<https://github.com/wall-nerds/wallening> up until a merge, to make
contribution simpler and allow things like bounties to close out more
easily

This pr is quite bulky, even stripping away map changes it's maybe 7000
LOC (We have a few maps that were modified with UpdatePaths, I am also
tentatively pring our test map, for future use.)
This may inhibit proper review, although that is part of why I am
willing to make it despite my perfectionism. Apologies in advance.

Due to the perspective shift, a lot of mapping work is going to need to
be done at some point. This comes in varying levels of priority. Many
wallmounts are offset by hand, some are stuck in the wall/basically
cannot be placed on the east/west/north edges of walls (posters), some
just don't look great good in their current position.

Tests are currently a minor bit yorked, I thought it was more important
to get this up then to clean them fully.

## What does it look like?


![dreamseeker_hBsU6wCu91](https://github.com/user-attachments/assets/5392fa3b-60f6-40ea-876f-e686f25f996a)

![dreamseeker_CTiK0Je5iR](https://github.com/user-attachments/assets/1aee23bd-a5ec-4679-b094-d044401b7222)

![dreamseeker_HYkS1Q9GRq](https://github.com/user-attachments/assets/bad8844b-3179-4856-8684-f912e14e844a)

![dreamseeker_Pa18tgyKYp](https://github.com/user-attachments/assets/c2e1d222-9e5c-4500-8829-dd065428644a)

![dreamseeker_BfOBwS2mjH](https://github.com/user-attachments/assets/7dc51153-111d-4b17-93c3-8389daa6b60b)

![dreamseeker_iJazOumiMQ](https://github.com/user-attachments/assets/5837e203-3865-4f60-854e-62b4875c6b99)

## Credits

<details>
<summary>Historical Mumbojumbo</summary>

I am gonna do my best to document how this project came to be. I am
operating off third party info and half remembered details, so if I'm
wrong please yell at me.

This project started sometime in late 2020, as a product of Rohesie
trying to integrate and make easier work from Mojave Sun (A recently
defunct fallout server) with /tg/.

Mojave Sun (Apparently this was LITERALLY JUST infrared baron, that man
is insane) was working with tall walls, IE walls that are 48px tall
instead of the normal 32. This was I THINK done based off a technical
prototype from aao7 proving A it was possible and B it didn't look like
dogwater.

This alongside oranges begging the art team for 3/4th walls (he meant
TGMC style) lead to Rohesie bringing on contributors from general /tg/,
including actionninja who would eventually take over as technical lead
and Kryson, who would define /tg/'s version of the artstyle. Much of the
formative aspects of this project are their work.

The project was coming along pretty well for a few months, but ran into
serious technical issues with `SIDE_MAP`, a byond map_format that allows
for simpler 3/4th rendering.
Due to BULLSHIT I will not detail here, the map format caused issues
both at random with flickering and heavily with multiz.

Concurrent with this, action stepped down after hacking out the
rendering tech and starting work on an icon cutter that would allow for
simpler icon generation, leaving ninjanomnom to manage the project.

Some time passed, and the project stalled out due to the technical
issues. Eventually I built a test case for the issues we had with
`SIDE_MAP` and convinced lummox jr (byond's developer) to explain how
the fuckin thing actually worked. This understanding made the project
theoretically possible, but did not resolve the problems with multi-z.
Resolving those required a full rework of how rendering like, worked. I
(alongside tattle) took over project development from ninjanomnom at
this time, and started work on Plane Cube (tgstation#69115), which when finished
would finally make the project technically feasible.

The time between then and now has been slow, progressive work. Many many
artists and technical folks have dumped their time into this (as you can
see from the credits). I will get into this more below but I would like
to explicitly thank (in no particular order) tattle, draco, arcanemusic,
actionninja, imaginos, viro and kylerace for keeping the project alive
in this time period. I would have curled up into a ball and died if I
had to do this all myself, your help has been indispensable.

</details>

<details>
<summary>Detailed Credits</summary>

Deep apologies if I have forgotten someone (I am sure I have, if someone
is you please contact me). I've done my best to collate from the git
log/my memory.

Thanks to (In no particular order):
Raccoff: Being funny to bully, creating threshold decals for airlocks
aa07: (I think) inspiring the project
ActionNinja: Laying the technical rock we build off, supporting me
despite byond trying to kill him, building the icon cutter that makes
this possible
ArcaneMusic: Artistic and technical work spanning from the project's
start to literally today, being a constant of motivation and positivity.
I can't list all the stuff he's done
Armhulen: Key rendering work (he's the reason thindows render right), an
upbeat personality and a kick in the ass. Love you arm
Azlan: Damn cool sprites, consistently
Ben10Omintrix: You know ben showed up just to make basic mobs work, he's
just fuckin like that man
BigBimmer: A large amount of bounty work, alongside just like, throwing
shit around. An absolute joy to work with
Capsandi: Plaques, blastdoors, artistic work early on
CapybaraExtravagante: Rendering work on wall frames
Draco: SO MUCH STUFF. Much of the spritework done over the past two
years is his, constantly engaged and will take on anything. I would have
given up if not for you
Floyd: Early rendering work, so early I don't even know the details.
Enjoy freedom brother
Imaginos16: A guiding hand through the middle years, handled much of the
sprite review and contribution for a good bit there
Iamgoofball: A dedication to detail and aesthetic goals, spends a lot of
effort dissecting feedback with a focus on making things as good as they
can be at the jump
Infrared: Part of the impetus for the project, made all the xenomorph
stuff in the MS style
Jacquerel: A bunch of little upkeep/technical things, has done so much
sprite gruntwork (WHY ARE THERE SO MANY PAINTING TYPES)
Justice12354: Solved a bunch of error sprites (and worked out how to
actually make prs to the project) Thanks bro!
Kryson: Built the artstyle of the project, carrying on for years even
when it was technically dying, only stopping to casually beat cancer. So
much of our style and art is Kryson
KylerAce: Handled annoying technical stuff for me, built window frame
logic and fully got rid of grilles.
LemonInTheDark: Rendering dirtywork, project management and just so much
fucking time in dreammaker editing sprites
Meyhazah: Table buttons, brass windows and alll the old style doors
Mothblocks: Has provided constant support, gave me a deadline and
motivation, erased worries about "it not being done", gave just SO much
money to fill in the critical holes in sprites. Thanks moth
MTandi: Contributed art despite his own blackjack and hookers club
opening right down the road, I'm sorry I rolled over some of your
sprites man I wish we had finished earlier
Ninjanomnomnom: Consulted on gags issues, kept things alive through some
truly shit times
oranges: This is his fault
Rohesie: Organized the effort, did much of the initial like, proof of
concept stuff. I hope you're doin well whatever you're up to.
san7890: Consulting on mapper UX/design problems, being my pet mapper
Senefi: Offsetting items with a focus on detail/the more unused
canidates
SimplyLogan: Detailed map work and mapper feedback, personally very kind
even if we end up talking past each other sometimes. Thank you!
SpaceSmithers: Just like, random mapping support out of nowhere, and
bein a straight up cool dude
Tattle: A bunch of misc project management stuff, organizing the
discord, managing the test server, dealing with all the mapping bullshit
for me, being my backup in case of bus. I know you think you didn't do
much but your presence and work have been a great help
Thunder12345: Came out of nowhere and just so much of the random
bounties, I'm kind of upset about how much we paid him
Time-Green: I hooked him in by fucking with stuff he made and now he's
just doin shit, thanks for helping out man!
Twaticus: Provided artistic feedback and authority for my poor feeble
coder brain, believed in the project for YEARS, was a constant source of
:heart: and affirmation
unit0016: I have no god damn idea who she is, popped out of nowhere on
the github one day and dealt with a bunch of annoying
rendering/refactoring. Godspeed random furry thank you for all your
effort and issue reports
Viro: A bunch of detailed spriting moving towards 3/4ths, both on and
off the wallening fork. If anyone believed this project would be done,
it was viro
Wallem: Artistic review and consultation, was my go-to guy for a long
time when the other two spritetainers were inactive
Waltermeldon: Cracked out a bunch of rendering work, he's the reason
windows look like not dogwater. Alongside floyd and action spent a TON
of time speaking to lummox/unearthing how byond rendering worked trying
to make this thing happen
ZephyrTFA: Added directional airlock helpers, dealt with a big fuckin
bugaboo that was living in my brain like it was nothing. Love you
brother

And finally:
The Mojave Sun development team. They provided a testbed for the idea,
committed hundreds and hundreds of hours to the artstyle, and were a
large reason we caught issues early enough to meaningfully deal with
them. Your work is a testament to what longterm effort and deep detailed
care produce. I hope you're doing well whatever you're up to. Go out
with a bang!
</details>

## Changelog
:cl: Raccoff, aa07, ActionNinja, ArcaneMusic, Armhulen, Azlan,
Ben10Omintrix, BigBimmer, Capsandi, CapybaraExtravagante, Draco, Floyd,
Iamgoofball, Imaginos16, Infrared, Jacquerel, Justice12354, Kryson,
KylerAce, LemonInTheDark, Meyhazah, Mothblocks, MTandi, Ninjanomnom,
oranges, Rohesie, Runi-c, san7890, Senefi, SimplyLogan, SomeAngryMiner,
SpaceSmithers, Tattle, Thunder12345, Time-Green, Twaticus, unit0016,
Viro, Waltermeldon, ZephyrTFA with thanks to the Mojave Sun team!
add: Resprites or offsets almost all "tall" objects in the game to match
a 3/4ths perspective
add: Bunch of rendering mumbo jumbo to make said 3/4ths perspective work
/:cl:

---------

Co-authored-by: Jacquerel <[email protected]>
Co-authored-by: san7890 <[email protected]>
Co-authored-by: = <[email protected]>
Co-authored-by: Capsandi <[email protected]>
Co-authored-by: ArcaneMusic <[email protected]>
Co-authored-by: tattle <[email protected]>
Co-authored-by: SomeAngryMiner <[email protected]>
Co-authored-by: KylerAce <[email protected]>
Co-authored-by: ArcaneMusic <[email protected]>
Co-authored-by: Time-Green <[email protected]>
Co-authored-by: lessthanthree <[email protected]>
Co-authored-by: Ben10Omintrix <[email protected]>
Co-authored-by: Runi-c <[email protected]>
Co-authored-by: Roryl-c <[email protected]>
Co-authored-by: tattle <[email protected]>
Co-authored-by: Senefi <[email protected]>
Co-authored-by: Justice <[email protected]>
Co-authored-by: BluBerry016 <[email protected]>
Co-authored-by: SmArtKar <[email protected]>
Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: SimplyLogan <[email protected]>
Co-authored-by: Emmett Gaines <[email protected]>
Co-authored-by: Rob Bailey <[email protected]>
Co-authored-by: MMMiracles <[email protected]>
  • Loading branch information
1 parent 8868a5d commit 4b4e9df
Show file tree
Hide file tree
Showing 1,308 changed files with 80,215 additions and 72,222 deletions.
239 changes: 136 additions & 103 deletions _maps/RandomRuins/IceRuins/icemoon_underground_mailroom.dmm

Large diffs are not rendered by default.

528 changes: 383 additions & 145 deletions _maps/RandomRuins/LavaRuins/lavaland_surface_elephant_graveyard.dmm

Large diffs are not rendered by default.

69 changes: 50 additions & 19 deletions _maps/RandomRuins/LavaRuins/lavaland_surface_gluttony.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,18 @@
dir = 8
},
/obj/structure/table/wood,
/obj/item/food/meat/slab/human/mutant/lizard,
/obj/item/food/meat/slab/human/mutant/lizard,
/obj/item/food/meat/slab/human/mutant/lizard,
/obj/item/food/meat/slab/human/mutant/lizard{
pixel_x = 3;
pixel_y = 2
},
/obj/item/food/meat/slab/human/mutant/lizard{
pixel_y = 10;
pixel_x = -3
},
/obj/item/food/meat/slab/human/mutant/lizard{
pixel_y = 17;
pixel_x = 5
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"eb" = (
Expand All @@ -46,13 +55,16 @@
/obj/structure/table/wood,
/obj/item/food/meat/slab/corgi{
pixel_x = 3;
pixel_y = 1
pixel_y = 4
},
/obj/item/food/meat/slab/corgi{
pixel_x = 5;
pixel_y = 5
pixel_y = 18
},
/obj/item/knife/combat/bone{
pixel_y = 10;
pixel_x = -4
},
/obj/item/knife/combat/bone,
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"eq" = (
Expand All @@ -77,7 +89,10 @@
/area/ruin/powered/gluttony)
"fa" = (
/obj/structure/table/wood,
/obj/item/food/meat/slab/human,
/obj/item/food/meat/slab/human{
pixel_y = 13;
pixel_x = -4
},
/obj/structure/stone_tile/block/cracked{
dir = 8
},
Expand Down Expand Up @@ -111,7 +126,9 @@
/turf/open/misc/asteroid/basalt/lava_land_surface,
/area/lavaland/surface/outdoors)
"ie" = (
/obj/item/veilrender/vealrender,
/obj/item/veilrender/vealrender{
pixel_y = 4
},
/obj/structure/stone_tile/slab/cracked{
dir = 6
},
Expand Down Expand Up @@ -155,8 +172,13 @@
dir = 1
},
/obj/structure/table/wood,
/obj/item/spear/bonespear,
/obj/item/slime_extract/silver,
/obj/item/spear/bonespear{
pixel_y = 9
},
/obj/item/slime_extract/silver{
pixel_y = 12;
pixel_x = -7
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"ls" = (
Expand Down Expand Up @@ -224,6 +246,12 @@
/area/ruin/powered/gluttony)
"rg" = (
/obj/structure/stone_tile/block/burnt,
/obj/item/clothing/gloves/butchering{
pixel_x = -2;
pixel_y = 6
},
/obj/effect/mob_spawn/corpse/human/miner,
/obj/effect/decal/cleanable/blood,
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"vU" = (
Expand Down Expand Up @@ -260,8 +288,14 @@
dir = 1
},
/obj/structure/table/wood,
/obj/item/food/meat/slab/goliath,
/obj/item/food/meat/slab/human/mutant/ethereal,
/obj/item/food/meat/slab/goliath{
pixel_y = 5;
pixel_x = 4
},
/obj/item/food/meat/slab/human/mutant/ethereal{
pixel_y = 15;
pixel_x = -9
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"zd" = (
Expand All @@ -282,7 +316,7 @@
dir = 4
},
/obj/effect/decal/cleanable/blood/tracks{
dir = 5
dir = 8
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
Expand Down Expand Up @@ -354,8 +388,6 @@
/obj/structure/stone_tile/slab/cracked{
dir = 1
},
/obj/effect/mob_spawn/corpse/human/miner,
/obj/item/clothing/gloves/butchering,
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"IM" = (
Expand Down Expand Up @@ -491,7 +523,9 @@
dir = 8
},
/obj/structure/table/wood,
/obj/item/food/meat/slab/human/mutant/moth,
/obj/item/food/meat/slab/human/mutant/moth{
pixel_y = 10
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"WR" = (
Expand All @@ -505,9 +539,6 @@
/obj/structure/stone_tile/block/burnt{
dir = 4
},
/obj/effect/decal/cleanable/blood/tracks{
dir = 10
},
/turf/open/indestructible/necropolis,
/area/ruin/powered/gluttony)
"Zd" = (
Expand Down
68 changes: 50 additions & 18 deletions _maps/RandomRuins/LavaRuins/lavaland_surface_greed.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
/area/lavaland/surface/outdoors)
"e" = (
/obj/structure/table/wood/poker,
/obj/item/gun/ballistic/revolver/russian/soul,
/obj/item/gun/ballistic/revolver/russian/soul{
pixel_y = 8
},
/obj/item/coin/diamond{
pixel_y = 8
},
/turf/open/floor/carpet,
/area/ruin/powered/greed)
"f" = (
Expand All @@ -19,12 +24,17 @@
/area/ruin/powered/greed)
"g" = (
/obj/structure/table/wood/poker,
/obj/item/coin/mythril,
/obj/item/coin/mythril{
pixel_y = 8
},
/obj/item/coin/adamantine{
pixel_y = 3;
pixel_x = -2
},
/turf/open/floor/carpet,
/area/ruin/powered/greed)
"h" = (
/obj/structure/table/wood/poker,
/obj/item/coin/diamond,
/obj/machinery/light/small/directional/west,
/turf/open/floor/carpet,
/area/ruin/powered/greed)
Expand All @@ -33,7 +43,6 @@
/area/ruin/powered/greed)
"j" = (
/obj/structure/table/wood/poker,
/obj/item/coin/adamantine,
/obj/machinery/light/small/directional/east,
/turf/open/floor/carpet,
/area/ruin/powered/greed)
Expand All @@ -54,7 +63,9 @@
/area/ruin/powered/greed)
"n" = (
/obj/structure/table/wood/poker,
/obj/item/stack/spacecash/c1000,
/obj/item/stack/spacecash/c1000{
pixel_y = 8
},
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"o" = (
Expand All @@ -63,33 +74,53 @@
/area/ruin/powered/greed)
"p" = (
/obj/structure/table/wood/poker,
/obj/item/stack/ore/gold,
/obj/item/stack/ore/gold{
pixel_y = 8
},
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"q" = (
/obj/structure/table/wood/poker,
/obj/item/stack/spacecash/c20,
/obj/item/stack/spacecash/c50,
/obj/item/stack/spacecash/c20{
pixel_y = 5
},
/obj/item/stack/spacecash/c50{
pixel_y = 8
},
/obj/machinery/light/small/directional/west,
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"r" = (
/obj/structure/table/wood/poker,
/obj/item/stack/spacecash/c500,
/obj/item/stack/spacecash/c100,
/obj/item/stack/spacecash/c1000,
/obj/item/stack/spacecash/c500{
pixel_y = 3
},
/obj/item/stack/spacecash/c100{
pixel_y = 6
},
/obj/item/stack/spacecash/c1000{
pixel_y = 8
},
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"s" = (
/obj/structure/table/wood/poker,
/obj/item/stack/spacecash/c200,
/obj/item/stack/spacecash/c200{
pixel_y = 8
},
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"u" = (
/obj/structure/table/wood/poker,
/obj/item/stack/spacecash/c500,
/obj/item/stack/spacecash/c100,
/obj/item/stack/spacecash/c1000,
/obj/item/stack/spacecash/c500{
pixel_y = 3
},
/obj/item/stack/spacecash/c100{
pixel_y = 5
},
/obj/item/stack/spacecash/c1000{
pixel_y = 8
},
/obj/machinery/light/small/directional/east,
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
Expand All @@ -100,6 +131,7 @@
/area/ruin/powered/greed)
"w" = (
/obj/machinery/light/small/directional/east,
/obj/item/coin/gold,
/turf/open/floor/engine/cult,
/area/ruin/powered/greed)
"J" = (
Expand Down Expand Up @@ -302,7 +334,7 @@ m
m
v
m
l
m
W
W
a
Expand All @@ -324,7 +356,7 @@ m
o
m
m
m
l
m
J
a
Expand All @@ -345,8 +377,8 @@ m
m
l
w
l
o
m
W
W
a
Expand Down
Loading

0 comments on commit 4b4e9df

Please sign in to comment.