Module 14 #18
Open
Module 14 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
screen capture of loggly logs from minikube running container
|
CorndelDevOps
approved these changes
Jan 5, 2023
| CLIENT_SECRET: <github_client secret here> | ||
| SECRET_KEY: <secretkey here> | ||
| CONNECTION_STRING: <connection string here to a mongodb> | ||
| #LOGGLY_TOKEN: <loggly token> # optional for external logging to loggly |
There was a problem hiding this comment.
nitpick: I don't think this needs to be commented out. It's clear from the inline comment later that this is optional, but leaving it empty should do the trick as well
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+1
to
+2
| #unpopulated secrets.yaml file. Populate and rename to secrets.yaml before deploying to minikube | ||
|
|
There was a problem hiding this comment.
nitpick: the name could follow the convention similar to .env.template, in which case this would be secrets.yaml.template, making it more obvious that this isn't a yaml file that you should use
|
|
||
|
|
||
| # MiniKube Set up | ||
| To configure a local minikube deployment of the todo-app. Assuming Docker desktop and Minikube are set up locally. |
There was a problem hiding this comment.
Check the phrasing here, because it looks a bit grammatically incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you are raising this PR against your own repository and not the original. If it says https://github.com/CorndelWithSoftwire in the search bar right now, you are in the wrong place!
Please also don't forget to submit the PR's url to Aptem afterwards (by clicking on the corresponding exercise component, pasting the url in the textbox that appears and then pressing the finish button).