Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bug in lbp page #2359

Merged
merged 4 commits into from
May 31, 2024
Merged

Fix some bug in lbp page #2359

merged 4 commits into from
May 31, 2024

Conversation

leonthuongto
Copy link
Contributor

Description

Please describe the purpose of this pull request.

Changes

  • Refactor show time remaining

Attached Links

  1. Jira ticket:
  2. Documents:

Checklist

  • Manual tests
  • The pull request doesn't affect existing feature

For reviewers

  • Ensure new code doesn't break existing features
  • Reviewer shouldn't merge if there are pending unresolved comments

@leonthuongto leonthuongto requested a review from thi-investax May 31, 2024 11:28
thi-investax
thi-investax reviewed May 31, 2024
View reviewed changes
src/utils/time.ts Outdated Show resolved Hide resolved
thi-investax
thi-investax reviewed May 31, 2024
View reviewed changes
src/utils/time.ts Outdated Show resolved Hide resolved
@thi-investax thi-investax merged commit 93057a3 into development May 31, 2024
0 of 2 checks passed
@thi-investax thi-investax deleted the fixbug/bug-on-template-file branch May 31, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thi-investax thi-investax thi-investax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonthuongto @thi-investax