Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1 🎫: Project setup (CRA redux architecture, images, GitHub actions, Linters, Documentation and License, etc) #11

Merged
merged 23 commits into from
Jan 23, 2024
Merged

Issue #1 🎫: Project setup (CRA redux architecture, images, GitHub actions, Linters, Documentation and License, etc) #11

merged 23 commits into from
Jan 23, 2024

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Jan 22, 2024 •
edited by mahammad-mostafa
Loading

Pull Request Summary for Issue #1 Completion

Added:

  • GitHub actions for Pull Request Linters.
  • Linters: eslint, stylelint.
  • VSCode: terminals.json.
  • Babel.
  • React Redux architecture.
  • project logos, favicons and apple-touch icon.
  • Stylesheets: normalize.css, _variables.scss and index.scss.
  • Redux store configuration with temporarily empty reducer.
  • API request helper for handling all api calls.
  • Page basic layout structure using Outlet component of react-router.
  • Included (.vscode / .env) inside .gitignore list.

Modified:

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres and Mahammad Mostafa for any queries or further assistance. 🌟

ITurres and others added 15 commits January 19, 2024 15:03
@ITurres
Setup: Project Setup - React-Redux Boilerplate
e776c61 
- GitHub actions.
- Linters: eslint, stylelint.
- VSCode: terminals.json.
- Babel.
- React Redux architecture.
- LICENSE and README.md.
@ITurres
Feat: Add all projects public images
27f0f22
@ITurres
Feat: Update 'index.html's title, author, description, and favicons
14b32ce
@ITurres
Chore: Add 'vehicles' and 'reservations' dummy json data
26651b8
@ITurres
Styles: Add '_variables.scss' with colors and fonts var
26bddc4
@ITurres
Styles: Update 'index.scss' with fonts and colors var
7efda5d
@ITurres
Chore: Update 'electron-to-chromium' package version
d985bf2
@ITurres
Linters: Resolve ESlint errors on 'app/' 'components/' and 'features/…
089a99d 
…' files
@mahammad-mostafa
Added .vscode directory to ignore list
68a6bc6
@mahammad-mostafa
Added ignore rules for sass keywords
f01100e
@mahammad-mostafa
Removed vscode local configuration for terminals
508debc
@mahammad-mostafa
Fixed apple touch icon link
564ccff
@mahammad-mostafa
Entered project correct name
683546d
@mahammad-mostafa
Rearranged arguments in render function
fda96c5
@mahammad-mostafa
Used redux store & react router with layout
e1902c6
@ITurres ITurres added documentation Improvements or additions to documentation enhancement New feature or request setup Project Setup - Linters - Workflows - Architecture - etc labels Jan 22, 2024
@ITurres ITurres linked an issue Jan 22, 2024 that may be closed by this pull request
[5pt] Setup and Configurations #1
Closed
15 tasks
@mahammad-mostafa mahammad-mostafa marked this pull request as ready for review January 22, 2024 23:50
@mahammad-mostafa mahammad-mostafa self-requested a review January 22, 2024 23:50
mahammad-mostafa
mahammad-mostafa approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@mahammad-mostafa mahammad-mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 Approved 🏆

Well done @ITurres 👏🏻 Your branch have been approved and you can merge 📦
🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇 🥇

@ITurres ITurres merged commit 526a624 into development Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahammad-mostafa mahammad-mostafa mahammad-mostafa approved these changes

Assignees

@mahammad-mostafa mahammad-mostafa

@ITurres ITurres

Labels
documentation Improvements or additions to documentation enhancement New feature or request setup Project Setup - Linters - Workflows - Architecture - etc
Projects
Tesla Booking (front-end) - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[5pt] Setup and Configurations
2 participants
@ITurres @mahammad-mostafa