Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Enh Drag&Drop: Drop on Trash #6972

Merged
merged 24 commits into from
Dec 17, 2024
Merged

🎨 [Frontend] Enh Drag&Drop: Drop on Trash #6972

merged 24 commits into from
Dec 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 17, 2024 •
edited
Loading

What do these changes do?

  • Enh/glitches in the Drag & Drop
    • Allow dropping Studies and Folders into the Trash
    • Show error messages coming from backend
    • Show warning when moving workspace content

Bonus:

  • A couple of aesthetic enhancements to the Market in Light theme
  • Remove unused Appearance files
  • Fix TIP

DropOnTrash

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 17, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 17, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 17, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh/dragdrop ii 🎨 [Frontend] Enh Drag&Drop: drop on Trash Dec 17, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh Drag&Drop: drop on Trash 🎨 [Frontend] Enh Drag&Drop: Drop on Trash Dec 17, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 17, 2024 10:55
@odeimaiz odeimaiz enabled auto-merge (squash) December 17, 2024 10:55
matusdrobuliak66
matusdrobuliak66 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Since "Move to Trash" is an operation that can be un-done ... perhaps it is a "yellow" button instead of red?

pcrespov
pcrespov approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets check the error messages.

sanderegg
sanderegg reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz
Copy link
Member Author

Since "Move to Trash" is an operation that can be un-done ... perhaps it is a "yellow" button instead of red?

@pcrespov Yellow it is:

MoveToTtrash

GitHK
GitHK reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz disabled auto-merge December 17, 2024 12:21
@odeimaiz odeimaiz enabled auto-merge (squash) December 17, 2024 12:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 38866c1 into ITISFoundation:master Dec 17, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
8 participants
@odeimaiz @giancarloromeo @jsaq007 @ignapas @GitHK @pcrespov @sanderegg @matusdrobuliak66