Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛🎨 [Frontend] Fix: Filter and focus Service Catalog items #6969

Merged
merged 9 commits into from
Dec 16, 2024
Merged

🐛🎨 [Frontend] Fix: Filter and focus Service Catalog items #6969

merged 9 commits into from
Dec 16, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 16, 2024 •
edited
Loading

What do these changes do?

  • Fix: bring back tab focus selection
  • Fix: bring back filter by tape
  • Always center Service Catalog window
  • Simpler widgets
  • Cleanup code

SrvCat

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 16, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 16, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 16, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 16, 2024 10:28
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: Service Catalog 🐛🎨 [Frontend] Fix: Filter and focus Service Catalog items Dec 16, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) December 16, 2024 10:29
pcrespov
pcrespov reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 95d208b into ITISFoundation:master Dec 16, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/service-catalog branch December 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@ignapas ignapas ignapas approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @giancarloromeo @ignapas @GitHK @pcrespov @sanderegg