Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Expose tags in Usage table #6961

Merged
merged 7 commits into from
Dec 16, 2024
Merged

🎨 [Frontend] Expose tags in Usage table #6961

merged 7 commits into from
Dec 16, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 13, 2024 •
edited
Loading

What do these changes do?

projectTags

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 13, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 13, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 13, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 13, 2024 10:52
@odeimaiz odeimaiz enabled auto-merge (squash) December 13, 2024 10:53
matusdrobuliak66
matusdrobuliak66 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qweqwe... that is my password man 🤕

pcrespov
pcrespov reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

Some suggestions:

  • rename Node column?
  • width should fit all displayed columns (tips: hide some)
  • color tags

GitHK
GitHK reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz
Copy link
Member Author

odeimaiz commented Dec 13, 2024 •
edited
Loading

  • rename Node column?

Rename to?

  • width should fit all displayed columns (tips: hide some)

Which ones should be hidden?

  • color tags

I only get the string

@odeimaiz odeimaiz disabled auto-merge December 16, 2024 07:38
@odeimaiz odeimaiz enabled auto-merge (squash) December 16, 2024 08:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 848339f into ITISFoundation:master Dec 16, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/show-tags-in-usage branch December 16, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
7 participants
@odeimaiz @giancarloromeo @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66