-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce license item checkout & release functionality (🗃️) #6960
✨ Introduce license item checkout & release functionality (🗃️) #6960
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6960 +/- ##
==========================================
- Coverage 87.06% 86.58% -0.49%
==========================================
Files 1611 1556 -55
Lines 63632 62162 -1470
Branches 2027 1778 -249
==========================================
- Hits 55400 53820 -1580
- Misses 7898 8033 +135
+ Partials 334 309 -25
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci 👍
services/web/server/src/simcore_service_webserver/licenses/_licensed_checkouts_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_checkouts_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_checkouts_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_checkouts_api.py
Show resolved
Hide resolved
...rc/simcore_service_resource_usage_tracker/services/modules/db/licensed_items_purchases_db.py
Show resolved
Hide resolved
...rc/simcore_service_resource_usage_tracker/services/modules/db/licensed_items_purchases_db.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_licensed_items_checkouts.py
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_licensed_items_checkouts.py
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_licensed_items_checkouts.py
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_licensed_items_checkouts.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just it would be cooler if you have separate PRs with separate concerns. these were a lot of bonuses and it makes more complicated to understand separate things.
...ls-library/src/models_library/api_schemas_resource_usage_tracker/licensed_items_checkouts.py
Show resolved
Hide resolved
...database/src/simcore_postgres_database/migration/versions/3720518f82a7_modify_licenses_db.py
Outdated
Show resolved
Hide resolved
...ages/service-library/src/servicelib/rabbitmq/rpc_interfaces/resource_usage_tracker/errors.py
Show resolved
Hide resolved
...rc/simcore_service_resource_usage_tracker/services/modules/db/licensed_items_checkouts_db.py
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
5786896
into
ITISFoundation:master
What do these changes do?
✨ Introduce license item
checkout
&release
functionality🗃️♻️ Rename
licensed_items_usages
-->licensed_items_checkouts
withcheckout_id
BONUS:
NEXT STEPS:
Related issue/s
How to test
Dev-ops checklist